BigQuery: Error parsing dot-star after array subscript

[nawhi]

Hi, thank you for this great library!

I noticed that in the BigQuery dialect, dot-star after an array subscript fails to parse.

Reproduction with v0.33.1:

import { parse } from "sql-parser-cst";

const sql = `
with x as (
  select [struct(1 as id, 'test' as name)] as arr
)
select arr[safe_offset(0)].*
from x
`;

parse(sql, { dialect: "bigquery" });

This throws the following error:

/path/to/project/node_modules/.pnpm/sql-parser-cst@0.33.1/node_modules/sql-parser-cst/lib/main.js:40
            throw new FormattedSyntaxError_2.FormattedSyntaxError(e, sql, options.filename);
                  ^

FormattedSyntaxError: Syntax Error: Unexpected "*"
Was expecting to see: "`", [A-Z,a-z,_], or whitespace
--> undefined:5:28
  |
5 | select arr[safe_offset(0)].*
  |                            ^
    at parse (/path/to/project/node_modules/.pnpm/sql-parser-cst@0.33.1/node_modules/sql-parser-cst/lib/main.js:40:19)
    at file:///path/to/project/index.js:11:1
    at ModuleJob.run (node:internal/modules/esm/module_job:274:25)
    at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:644:26)
    at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:117:5)

Node.js v22.16.0

[nawhi]

It also seems to throw even if acceptUnsupportedGrammar is set to true, which from my understanding should make it parse as an unsupported statement instead.

[nene]

Thanks for reporting.

The acceptUnsupportedGrammar doesn't really work well. It was a quick hack I did, which unfortunately only works when there's some totally unsupported SQL statement like CREATE SPELL hello;.

This issue is not really about array subscripts, but a more general missing support for the .* syntax. Currently only foo.* is supported. One also can't do foo.bar.*.

So in general we'll need to support <expression>.* syntax.

• SELECT expression.* in BigQuery docs