Add HasDefaultValue() to IGdtfDmxChannelFunction interface

[jordan-walters]

We at Chamsys/Chauvet would really benefit from the addition of a HasDefaultValue() function on the IGdtfDmxChannelFunction interface.
At present 0 (zero) is returned if there is a DefaultValue set to 0, or if there is no DefaultValue.
If there is no DefaultValue we would then want to assign our own default value - depending on the Channel's attribute.

My code enhancement is based on the already existing IGdtfDmxChannel HasHighlight() function.

Attached are the 5 codefiles I changed.

HasDefaultValue.zip

Many thanks

Jordan Walters
Software Engineer
ChamSys Ltd
Unit H5 Adanac North, Adanac Drive, Nursling, Southampton, SO16 0BT
E: jordan.walters@chamsys.co.uk
W: www.chamsys.co.uk

[welcome]

Thanks for opening your first issue here! Be sure to follow the issue template!

[petrvanekrobe]

Hi @jordan-walters , thank you for reaching out. We will come back on this.

[jordan-walters]

Hi @petrvanekrobe, is there any progress with this?

I would also like to add another accessor function to return the GDTF Version from the embedded description xml.
I will implement it locally and submit my changes to you soon.

Last question. Can I be added to the GitHub repository for libMVRgdtf so I can submit merge requests to make it easier for us both?

Regards
Jordan

[petrvanekrobe]

Hi @jordan-walters,

i am very sorry, i missed messaging you back. We looked it already in March. We have discussed the default value for Default in Channel Function. Result: we will add clarification to the Default value of Channel Function, it will equal the DMXFrom. Here is a new PR: #267 Add default value to the ChannelFunction - Default field. We will also modify the GDTF builder to handle adding of new channel function and prefill the default value = DMXFrom. This will ensure that the default value would always be present and within correct range, resulting in more correct GDTF files, rather then relying on each software to handle this on their own in different ways. We believe that this is a better solution.

I would also like to add another accessor function to return the GDTF Version from the embedded description xml.
I will implement it locally and submit my changes to you soon.

I am not using the libMVRgdtf, so i cannot comment on accessor to the version, but it sounds OK to me.

As for PRs, i have checked and there is no need for extra permissions, you can clone the project and submit PRs.

[jordan-walters]

Hi @petrvanekrobe
Thank you for addressing the default channel function issue.
And for agreeing to add GDTF version accessor.

In a clone of the libMVRgdtf repository, I am unable to push my branch due to permission denied....

"git -c diff.mnemonicprefix=false -c core.quotepath=false --no-optional-locks push -v origin master:master
remote: Permission to mvrdevelopment/libMVRgdtf.git denied to jordan-walters.
fatal: unable to access 'https://github.com/mvrdevelopment/libMVRgdtf.git/': The requested URL returned error: 403
Pushing to https://github.com/mvrdevelopment/libMVRgdtf.git"

[petrvanekrobe]

Hi @jordan-walters, you cannot push to this repo. You need to push to your forked repo in Github and then make a PR from repo - your branch (ideally not master, so you can rebase easily) to this repo.

[jordan-walters]

Hi @petrvanekrobe
I forked the main repo, and created a branch on my fork, pushed that to origin, and have created the following merge request

#86

Could you review?

Jordan