Removed unnecessary comments.

papafe · papafe · commit 59c3a47892fb · 2025-09-09T11:09:12.000+02:00
diff --git a/src/MongoDB.Bson/IO/BsonReader.cs b/src/MongoDB.Bson/IO/BsonReader.cs
@@ -321,14 +321,12 @@ public virtual IByteBuffer ReadRawBsonArray()
             // overridden in BsonBinaryReader to read the raw bytes from the stream
             // for all other streams, deserialize the array and reserialize it using a BsonBinaryWriter to get the raw bytes
 
-            //QUESTION Is it correct we only need a default domain here?
             var deserializationContext = BsonDeserializationContext.CreateRoot(this, BsonSerializer.DefaultSerializationDomain);
             var array = BsonArraySerializer.Instance.Deserialize(deserializationContext);
 
             using (var memoryStream = new MemoryStream())
             using (var bsonWriter = new BsonBinaryWriter(memoryStream, BsonBinaryWriterSettings.Defaults))
             {
-                //QUESTION Is it correct we only need a default domain here?
                 var serializationContext = BsonSerializationContext.CreateRoot(bsonWriter, BsonSerializer.DefaultSerializationDomain);
                 bsonWriter.WriteStartDocument();
                 var startPosition = memoryStream.Position + 3; // just past BsonType, "x" and null byte
@@ -353,7 +351,6 @@ public virtual IByteBuffer ReadRawBsonDocument()
             // overridden in BsonBinaryReader to read the raw bytes from the stream
             // for all other streams, deserialize the document and use ToBson to get the raw bytes
 
-            //QUESTION Is it correct we only need a default domain here?
             var deserializationContext = BsonDeserializationContext.CreateRoot(this, BsonSerializer.DefaultSerializationDomain);
             var document = BsonDocumentSerializer.Instance.Deserialize(deserializationContext);
             var bytes = document.ToBson();
diff --git a/src/MongoDB.Bson/IO/BsonWriter.cs b/src/MongoDB.Bson/IO/BsonWriter.cs
@@ -326,14 +326,12 @@ public virtual void WriteRawBsonArray(IByteBuffer slice)
                 stream.Position = 0;
                 using (var reader = new BsonBinaryReader(stream, BsonBinaryReaderSettings.Defaults))
                 {
-                    //QUESTION Is it correct we only need a default domain here?
                     var deserializationContext = BsonDeserializationContext.CreateRoot(reader, BsonSerializer.DefaultSerializationDomain);
                     reader.ReadStartDocument();
                     reader.ReadName("x");
                     var array = BsonArraySerializer.Instance.Deserialize(deserializationContext);
                     reader.ReadEndDocument();
 
-                    //QUESTION Is it correct we only need a default domain here?
                     var serializationContext = BsonSerializationContext.CreateRoot(this, BsonSerializer.DefaultSerializationDomain);
                     BsonArraySerializer.Instance.Serialize(serializationContext, array);
                 }
@@ -352,11 +350,9 @@ public virtual void WriteRawBsonDocument(IByteBuffer slice)
             using (var stream = new ByteBufferStream(slice, ownsBuffer: false))
             using (var bsonReader = new BsonBinaryReader(stream, BsonBinaryReaderSettings.Defaults))
             {
-                //QUESTION Is it correct we only need a default domain here?
                 var deserializationContext = BsonDeserializationContext.CreateRoot(bsonReader, BsonSerializer.DefaultSerializationDomain);
                 var document = BsonDocumentSerializer.Instance.Deserialize(deserializationContext);
 
-                //QUESTION Is it correct we only need a default domain here?
                 var serializationContext = BsonSerializationContext.CreateRoot(this, BsonSerializer.DefaultSerializationDomain);
                 BsonDocumentSerializer.Instance.Serialize(serializationContext, document);
             }
diff --git a/src/MongoDB.Bson/IO/ElementAppendingBsonWriter.cs b/src/MongoDB.Bson/IO/ElementAppendingBsonWriter.cs
@@ -60,7 +60,6 @@ public override void WriteEndDocument()
                 Wrapped.PushSettings(_settingsConfigurator);
                 try
                 {
-                    //QUESTION Is it correct we only need a default domain here?
                     var context = BsonSerializationContext.CreateRoot(Wrapped, BsonSerializer.DefaultSerializationDomain);
                     foreach (var element in _elements)
                     {
diff --git a/src/MongoDB.Bson/ObjectModel/BsonDocument.cs b/src/MongoDB.Bson/ObjectModel/BsonDocument.cs
@@ -331,7 +331,6 @@ public static BsonDocument Parse(string json)
         {
             using (var jsonReader = new JsonReader(json))
             {
-                //QUESTION Is it correct we only need a default domain here?
                 var context = BsonDeserializationContext.CreateRoot(jsonReader, BsonSerializer.DefaultSerializationDomain);
                 var document = BsonDocumentSerializer.Instance.Deserialize(context);
                 if (!jsonReader.IsAtEndOfFile())
diff --git a/src/MongoDB.Bson/ObjectModel/LazyBsonArray.cs b/src/MongoDB.Bson/ObjectModel/LazyBsonArray.cs
@@ -173,7 +173,6 @@ private IEnumerable<BsonValue> MaterializeThisLevel()
             using (var stream = new ByteBufferStream(_slice, ownsBuffer: false))
             using (var bsonReader = new BsonBinaryReader(stream, _readerSettings))
             {
-                //QUESTION Is it correct we only need a default domain here?
                 var context = BsonDeserializationContext.CreateRoot(bsonReader, BsonSerializer.DefaultSerializationDomain);
 
                 bsonReader.ReadStartDocument();
diff --git a/src/MongoDB.Bson/ObjectModel/LazyBsonDocument.cs b/src/MongoDB.Bson/ObjectModel/LazyBsonDocument.cs
@@ -184,7 +184,6 @@ private IEnumerable<BsonElement> MaterializeThisLevel()
             using (var stream = new ByteBufferStream(_slice, ownsBuffer: false))
             using (var bsonReader = new BsonBinaryReader(stream, _readerSettings))
             {
-                //QUESTION Is it correct we only need a default domain here?
                 var context = BsonDeserializationContext.CreateRoot(bsonReader, BsonSerializer.DefaultSerializationDomain);
 
                 bsonReader.ReadStartDocument();
diff --git a/src/MongoDB.Bson/ObjectModel/RawBsonArray.cs b/src/MongoDB.Bson/ObjectModel/RawBsonArray.cs
@@ -128,7 +128,6 @@ public override IEnumerable<BsonValue> Values
                 using (var stream = new ByteBufferStream(_slice, ownsBuffer: false))
                 using (var bsonReader = new BsonBinaryReader(stream, _readerSettings))
                 {
-                    //QUESTION Is it correct we only need a default domain here?
                     var context = BsonDeserializationContext.CreateRoot(bsonReader, BsonSerializer.DefaultSerializationDomain);
 
                     bsonReader.ReadStartDocument();
@@ -168,7 +167,6 @@ public override BsonValue this[int index]
                         bsonReader.SkipName();
                         if (i == index)
                         {
-                            //QUESTION Is it correct we only need a default domain here?
                             var context = BsonDeserializationContext.CreateRoot(bsonReader, BsonSerializer.DefaultSerializationDomain);
                             return DeserializeBsonValue(context);
                         }
@@ -316,7 +314,6 @@ public override bool Contains(BsonValue value)
             using (var stream = new ByteBufferStream(_slice, ownsBuffer: false))
             using (var bsonReader = new BsonBinaryReader(stream, _readerSettings))
             {
-                //QUESTION Is it correct we only need a default domain here?
                 var context = BsonDeserializationContext.CreateRoot(bsonReader, BsonSerializer.DefaultSerializationDomain);
 
                 bsonReader.ReadStartDocument();
@@ -345,7 +342,6 @@ public override void CopyTo(BsonValue[] array, int arrayIndex)
             using (var stream = new ByteBufferStream(_slice, ownsBuffer: false))
             using (var bsonReader = new BsonBinaryReader(stream, _readerSettings))
             {
-                //QUESTION Is it correct we only need a default domain here?
                 var context = BsonDeserializationContext.CreateRoot(bsonReader, BsonSerializer.DefaultSerializationDomain);
 
                 bsonReader.ReadStartDocument();
@@ -387,7 +383,6 @@ public override IEnumerator<BsonValue> GetEnumerator()
             using (var stream = new ByteBufferStream(_slice, ownsBuffer: false))
             using (var bsonReader = new BsonBinaryReader(stream, _readerSettings))
             {
-                //QUESTION Is it correct we only need a default domain here?
                 var context = BsonDeserializationContext.CreateRoot(bsonReader, BsonSerializer.DefaultSerializationDomain);
 
                 bsonReader.ReadStartDocument();
@@ -434,7 +429,6 @@ public override int IndexOf(BsonValue value, int index, int count)
             using (var stream = new ByteBufferStream(_slice, ownsBuffer: false))
             using (var bsonReader = new BsonBinaryReader(stream, _readerSettings))
             {
-                //QUESTION Is it correct we only need a default domain here?
                 var context = BsonDeserializationContext.CreateRoot(bsonReader, BsonSerializer.DefaultSerializationDomain);
 
                 bsonReader.ReadStartDocument();
@@ -495,7 +489,6 @@ public BsonArray Materialize(BsonBinaryReaderSettings binaryReaderSettings)
             using (var stream = new MemoryStream(bytes))
             using (var reader = new BsonBinaryReader(stream, binaryReaderSettings))
             {
-                //QUESTION Is it correct we only need a default domain here?
                 var context = BsonDeserializationContext.CreateRoot(reader, BsonSerializer.DefaultSerializationDomain);
                 var materializedDocument = BsonDocumentSerializer.Instance.Deserialize(context);
                 return materializedDocument["array"].AsBsonArray;
diff --git a/src/MongoDB.Bson/ObjectModel/RawBsonDocument.cs b/src/MongoDB.Bson/ObjectModel/RawBsonDocument.cs
@@ -102,7 +102,6 @@ public override IEnumerable<BsonElement> Elements
                 using (var stream = new ByteBufferStream(_slice, ownsBuffer: false))
                 using (var bsonReader = new BsonBinaryReader(stream, _readerSettings))
                 {
-                    //QUESTION Is it correct we only need a default domain here?
                     var context = BsonDeserializationContext.CreateRoot(bsonReader, BsonSerializer.DefaultSerializationDomain);
 
                     bsonReader.ReadStartDocument();
@@ -165,7 +164,6 @@ public override IEnumerable<BsonValue> Values
                 using (var stream = new ByteBufferStream(_slice, ownsBuffer: false))
                 using (var bsonReader = new BsonBinaryReader(stream, _readerSettings))
                 {
-                    //QUESTION Is it correct we only need a default domain here?
                     var context = BsonDeserializationContext.CreateRoot(bsonReader, BsonSerializer.DefaultSerializationDomain);
 
                     bsonReader.ReadStartDocument();
@@ -354,7 +352,6 @@ public override bool ContainsValue(BsonValue value)
             using (var stream = new ByteBufferStream(_slice, ownsBuffer: false))
             using (var bsonReader = new BsonBinaryReader(stream, _readerSettings))
             {
-                //QUESTION Is it correct we only need a default domain here?
                 var context = BsonDeserializationContext.CreateRoot(bsonReader, BsonSerializer.DefaultSerializationDomain);
 
                 bsonReader.ReadStartDocument();
@@ -411,7 +408,6 @@ public override BsonElement GetElement(int index)
             using (var stream = new ByteBufferStream(_slice, ownsBuffer: false))
             using (var bsonReader = new BsonBinaryReader(stream, _readerSettings))
             {
-                //QUESTION Is it correct we only need a default domain here?
                 var context = BsonDeserializationContext.CreateRoot(bsonReader, BsonSerializer.DefaultSerializationDomain);
 
                 bsonReader.ReadStartDocument();
@@ -467,7 +463,6 @@ public override IEnumerator<BsonElement> GetEnumerator()
             using (var stream = new ByteBufferStream(_slice, ownsBuffer: false))
             using (var bsonReader = new BsonBinaryReader(stream, _readerSettings))
             {
-                //QUESTION Is it correct we only need a default domain here?
                 var context = BsonDeserializationContext.CreateRoot(bsonReader, BsonSerializer.DefaultSerializationDomain);
 
                 bsonReader.ReadStartDocument();
@@ -499,7 +494,6 @@ public override BsonValue GetValue(int index)
             using (var stream = new ByteBufferStream(_slice, ownsBuffer: false))
             using (var bsonReader = new BsonBinaryReader(stream, _readerSettings))
             {
-                //QUESTION Is it correct we only need a default domain here?
                 var context = BsonDeserializationContext.CreateRoot(bsonReader, BsonSerializer.DefaultSerializationDomain);
 
                 bsonReader.ReadStartDocument();
@@ -582,7 +576,6 @@ public BsonDocument Materialize(BsonBinaryReaderSettings binaryReaderSettings)
             using (var stream = new ByteBufferStream(_slice, ownsBuffer: false))
             using (var reader = new BsonBinaryReader(stream, binaryReaderSettings))
             {
-                //QUESTION Is it correct we only need a default domain here?
                 var context = BsonDeserializationContext.CreateRoot(reader, BsonSerializer.DefaultSerializationDomain);
                 return BsonDocumentSerializer.Instance.Deserialize(context);
             }
@@ -706,7 +699,6 @@ public override bool TryGetElement(string name, out BsonElement element)
             using (var stream = new ByteBufferStream(_slice, ownsBuffer: false))
             using (var bsonReader = new BsonBinaryReader(stream, _readerSettings))
             {
-                //QUESTION Is it correct we only need a default domain here?
                 var context = BsonDeserializationContext.CreateRoot(bsonReader, BsonSerializer.DefaultSerializationDomain);
 
                 bsonReader.ReadStartDocument();
@@ -742,7 +734,6 @@ public override bool TryGetValue(string name, out BsonValue value)
             using (var stream = new ByteBufferStream(_slice, ownsBuffer: false))
             using (var bsonReader = new BsonBinaryReader(stream, _readerSettings))
             {
-                //QUESTION Is it correct we only need a default domain here?
                 var context = BsonDeserializationContext.CreateRoot(bsonReader, BsonSerializer.DefaultSerializationDomain);
 
                 bsonReader.ReadStartDocument();
diff --git a/src/MongoDB.Bson/Serialization/BsonSerializationContext.cs b/src/MongoDB.Bson/Serialization/BsonSerializationContext.cs
@@ -143,7 +143,7 @@ internal Builder(BsonSerializationContext other, IBsonWriter writer, IBsonSerial
                     _isDynamicType = other._isDynamicType;
                 }
 
-                /* QUESTION I removed the part where we set _isDynamicType from the BsonDefaults, and delay it until we have a serialization domain (when we build the SerializationContext).
+                /* FP I removed the part where we set _isDynamicType from the BsonDefaults, and delay it until we have a serialization domain (when we build the SerializationContext).
                  * This is technically changing the public behaviour, but it's in a builder, I do not thing it will affect anyone. Same done for the deserialization context.
                  */
             }
diff --git a/src/MongoDB.Bson/Serialization/BsonSerializationInfo.cs b/src/MongoDB.Bson/Serialization/BsonSerializationInfo.cs
@@ -155,7 +155,7 @@ public BsonValue SerializeValue(object value)
             var tempDocument = new BsonDocument();
             using (var bsonWriter = new BsonDocumentWriter(tempDocument))
             {
-                //QUESTION Is it correct we only need a standard domain here?
+                //QUESTION Is it correct we only need a default domain here?
                 var context = BsonSerializationContext.CreateRoot(bsonWriter, BsonSerializer.DefaultSerializationDomain);
                 bsonWriter.WriteStartDocument();
                 bsonWriter.WriteName("value");
@@ -165,6 +165,7 @@ public BsonValue SerializeValue(object value)
             }
         }
 
+        //DOMAIN-API This method should be probably removed, it's never used.
         /// <summary>
         /// Serializes the values.
         /// </summary>
@@ -191,6 +192,7 @@ public BsonArray SerializeValues(IEnumerable values)
             }
         }
 
+        //DOMAIN-API This method should be probably removed, it's never used.
         /// <summary>
         /// Creates a new BsonSerializationInfo object using the elementName provided and copying all other attributes.
         /// </summary>
diff --git a/src/MongoDB.Bson/Serialization/BsonSerializer.cs b/src/MongoDB.Bson/Serialization/BsonSerializer.cs
@@ -34,7 +34,6 @@ static BsonSerializer()
             _serializationDomain = new BsonSerializationDomain("MAIN");
         }
 
-        //QUESTION I think we should have another property here, called StandardSerializationDomain, which would have only the standard serializers and conventions registered.
         internal static IBsonSerializationDomain DefaultSerializationDomain => _serializationDomain;
 
         // public static properties
diff --git a/src/MongoDB.Bson/Serialization/IBsonSerializerExtensions.cs b/src/MongoDB.Bson/Serialization/IBsonSerializerExtensions.cs
@@ -104,7 +104,6 @@ public static BsonValue ToBsonValue(this IBsonSerializer serializer, object valu
             var document = new BsonDocument();
             using (var writer = new BsonDocumentWriter(document))
             {
-                //QUESTION Is it correct we only need a default domain here?
                 var context = BsonSerializationContext.CreateRoot(writer, BsonSerializer.DefaultSerializationDomain);
                 writer.WriteStartDocument();
                 writer.WriteName("x");
@@ -126,7 +125,6 @@ public static BsonValue ToBsonValue<TValue>(this IBsonSerializer<TValue> seriali
             var document = new BsonDocument();
             using (var writer = new BsonDocumentWriter(document))
             {
-                //QUESTION Is it correct we only need a default domain here?
                 var context = BsonSerializationContext.CreateRoot(writer, BsonSerializer.DefaultSerializationDomain);
                 writer.WriteStartDocument();
                 writer.WriteName("x");
diff --git a/src/MongoDB.Driver/Authentication/Oidc/AzureOidcCallback.cs b/src/MongoDB.Driver/Authentication/Oidc/AzureOidcCallback.cs
@@ -46,7 +46,7 @@ protected override OidcAccessToken ProcessHttpResponse(Stream responseStream)
             using var responseReader = new StreamReader(responseStream);
             using var jsonReader = new JsonReader(responseReader);
 
-            var context = BsonDeserializationContext.CreateRoot(jsonReader, BsonSerializer.DefaultSerializationDomain);  //QUESTION Is it ok to use the default domain here?
+            var context = BsonDeserializationContext.CreateRoot(jsonReader, BsonSerializer.DefaultSerializationDomain);
             var document = BsonDocumentSerializer.Instance.Deserialize(context);
 
             var accessToken = document.GetValue("access_token");
diff --git a/src/MongoDB.Driver/Core/Bindings/CoreSession.cs b/src/MongoDB.Driver/Core/Bindings/CoreSession.cs
@@ -447,7 +447,6 @@ public void WasUsed()
         // private methods
         private IReadOperation<BsonDocument> CreateAbortTransactionOperation(OperationContext operationContext)
         {
-            //QUESTION Is it correct we only need a default domain here?
             return new AbortTransactionOperation(_currentTransaction.RecoveryToken, GetTransactionWriteConcern(operationContext));
         }
 
diff --git a/src/MongoDB.Driver/Core/WireProtocol/Messages/Encoders/BinaryEncoders/CommandMessageBinaryEncoder.cs b/src/MongoDB.Driver/Core/WireProtocol/Messages/Encoders/BinaryEncoders/CommandMessageBinaryEncoder.cs
@@ -29,7 +29,7 @@ internal sealed class CommandMessageBinaryEncoder : MessageBinaryEncoderBase, IM
     {
         private const int EncryptedMaxBatchSize = 2 * 1024 * 1024; // 2 MiB
         private static readonly ICommandMessageSectionFormatter<Type0CommandMessageSection> __type0SectionFormatter = new Type0SectionFormatter(BsonSerializer.DefaultSerializationDomain);
-        //QUESTION Looking at the spec and our implementation, it seems that type 0 sections always serialize/deserialize RawBsonDocument, so they should use the standard domain. Am I missing something?
+        //QUESTION Looking at the spec and our implementation, it seems that type 0 sections always serialize/deserialize RawBsonDocument, so they should use the default domain. Am I missing something?
 
         // constructors
         public CommandMessageBinaryEncoder(Stream stream, MessageEncoderSettings encoderSettings)
diff --git a/src/MongoDB.Driver/Core/WireProtocol/Messages/Encoders/JsonEncoders/QueryMessageJsonEncoder.cs b/src/MongoDB.Driver/Core/WireProtocol/Messages/Encoders/JsonEncoders/QueryMessageJsonEncoder.cs
@@ -32,7 +32,6 @@ public QueryMessageJsonEncoder(TextReader textReader, TextWriter textWriter, Mes
             : base(textReader, textWriter, encoderSettings)
         {
             _serializationDomain = encoderSettings?.GetOrDefault<IBsonSerializationDomain>(MessageEncoderSettingsName.SerializationDomain, null) ?? BsonSerializer.DefaultSerializationDomain;
-            //QUESTION: Should we use the default serialization domain here? I think it's appropriate.
         }
 
         // methods
diff --git a/src/MongoDB.Driver/MongoClientSettings.cs b/src/MongoDB.Driver/MongoClientSettings.cs
@@ -477,7 +477,6 @@ public ReadPreference ReadPreference
 
         IBsonSerializationDomain IInheritableMongoClientSettings.SerializationDomain
         {
-            //QUESTION Is this reasonable?
             get => _serializationDomain ?? BsonSerializer.DefaultSerializationDomain;
             set
             {
diff --git a/src/MongoDB.Driver/MongoCollectionSettings.cs b/src/MongoDB.Driver/MongoCollectionSettings.cs
diff --git a/src/MongoDB.Driver/MongoDatabaseSettings.cs b/src/MongoDB.Driver/MongoDatabaseSettings.cs

Original file line number	Diff line number	Diff line change
`@@ -326,14 +326,12 @@ public virtual void WriteRawBsonArray(IByteBuffer slice)`
`326`	`326`	`stream.Position = 0;`
`327`	`327`	`using (var reader = new BsonBinaryReader(stream, BsonBinaryReaderSettings.Defaults))`
`328`	`328`	`{`
`329`		`- //QUESTION Is it correct we only need a default domain here?`
`330`	`329`	`var deserializationContext = BsonDeserializationContext.CreateRoot(reader, BsonSerializer.DefaultSerializationDomain);`
`331`	`330`	`reader.ReadStartDocument();`
`332`	`331`	`reader.ReadName("x");`
`333`	`332`	`var array = BsonArraySerializer.Instance.Deserialize(deserializationContext);`
`334`	`333`	`reader.ReadEndDocument();`
`335`	`334`
`336`		`- //QUESTION Is it correct we only need a default domain here?`
`337`	`335`	`var serializationContext = BsonSerializationContext.CreateRoot(this, BsonSerializer.DefaultSerializationDomain);`
`338`	`336`	`BsonArraySerializer.Instance.Serialize(serializationContext, array);`
`339`	`337`	`}`
`@@ -352,11 +350,9 @@ public virtual void WriteRawBsonDocument(IByteBuffer slice)`
`352`	`350`	`using (var stream = new ByteBufferStream(slice, ownsBuffer: false))`
`353`	`351`	`using (var bsonReader = new BsonBinaryReader(stream, BsonBinaryReaderSettings.Defaults))`
`354`	`352`	`{`
`355`		`- //QUESTION Is it correct we only need a default domain here?`
`356`	`353`	`var deserializationContext = BsonDeserializationContext.CreateRoot(bsonReader, BsonSerializer.DefaultSerializationDomain);`
`357`	`354`	`var document = BsonDocumentSerializer.Instance.Deserialize(deserializationContext);`
`358`	`355`
`359`		`- //QUESTION Is it correct we only need a default domain here?`
`360`	`356`	`var serializationContext = BsonSerializationContext.CreateRoot(this, BsonSerializer.DefaultSerializationDomain);`
`361`	`357`	`BsonDocumentSerializer.Instance.Serialize(serializationContext, document);`
`362`	`358`	`}`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,6 @@ public override void WriteEndDocument()`
`60`	`60`	`Wrapped.PushSettings(_settingsConfigurator);`
`61`	`61`	`try`
`62`	`62`	`{`
`63`		`- //QUESTION Is it correct we only need a default domain here?`
`64`	`63`	`var context = BsonSerializationContext.CreateRoot(Wrapped, BsonSerializer.DefaultSerializationDomain);`
`65`	`64`	`foreach (var element in _elements)`
`66`	`65`	`{`
Original file line number	Diff line number	Diff line change
`@@ -331,7 +331,6 @@ public static BsonDocument Parse(string json)`
`331`	`331`	`{`
`332`	`332`	`using (var jsonReader = new JsonReader(json))`
`333`	`333`	`{`
`334`		`- //QUESTION Is it correct we only need a default domain here?`
`335`	`334`	`var context = BsonDeserializationContext.CreateRoot(jsonReader, BsonSerializer.DefaultSerializationDomain);`
`336`	`335`	`var document = BsonDocumentSerializer.Instance.Deserialize(context);`
`337`	`336`	`if (!jsonReader.IsAtEndOfFile())`
Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,6 @@ private IEnumerable<BsonValue> MaterializeThisLevel()`
`173`	`173`	`using (var stream = new ByteBufferStream(_slice, ownsBuffer: false))`
`174`	`174`	`using (var bsonReader = new BsonBinaryReader(stream, _readerSettings))`
`175`	`175`	`{`
`176`		`- //QUESTION Is it correct we only need a default domain here?`
`177`	`176`	`var context = BsonDeserializationContext.CreateRoot(bsonReader, BsonSerializer.DefaultSerializationDomain);`
`178`	`177`
`179`	`178`	`bsonReader.ReadStartDocument();`
Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,6 @@ private IEnumerable<BsonElement> MaterializeThisLevel()`
`184`	`184`	`using (var stream = new ByteBufferStream(_slice, ownsBuffer: false))`
`185`	`185`	`using (var bsonReader = new BsonBinaryReader(stream, _readerSettings))`
`186`	`186`	`{`
`187`		`- //QUESTION Is it correct we only need a default domain here?`
`188`	`187`	`var context = BsonDeserializationContext.CreateRoot(bsonReader, BsonSerializer.DefaultSerializationDomain);`
`189`	`188`
`190`	`189`	`bsonReader.ReadStartDocument();`
Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ internal Builder(BsonSerializationContext other, IBsonWriter writer, IBsonSerial`
`143`	`143`	`_isDynamicType = other._isDynamicType;`
`144`	`144`	`}`
`145`	`145`
`146`		`- /* QUESTION I removed the part where we set _isDynamicType from the BsonDefaults, and delay it until we have a serialization domain (when we build the SerializationContext).`
	`146`	`+ /* FP I removed the part where we set _isDynamicType from the BsonDefaults, and delay it until we have a serialization domain (when we build the SerializationContext).`
`147`	`147`	`* This is technically changing the public behaviour, but it's in a builder, I do not thing it will affect anyone. Same done for the deserialization context.`
`148`	`148`	`*/`
`149`	`149`	`}`
Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,7 @@ public BsonValue SerializeValue(object value)`
`155`	`155`	`var tempDocument = new BsonDocument();`
`156`	`156`	`using (var bsonWriter = new BsonDocumentWriter(tempDocument))`
`157`	`157`	`{`
`158`		`- //QUESTION Is it correct we only need a standard domain here?`
	`158`	`+ //QUESTION Is it correct we only need a default domain here?`
`159`	`159`	`var context = BsonSerializationContext.CreateRoot(bsonWriter, BsonSerializer.DefaultSerializationDomain);`
`160`	`160`	`bsonWriter.WriteStartDocument();`
`161`	`161`	`bsonWriter.WriteName("value");`
`@@ -165,6 +165,7 @@ public BsonValue SerializeValue(object value)`
`165`	`165`	`}`
`166`	`166`	`}`
`167`	`167`
	`168`	`+ //DOMAIN-API This method should be probably removed, it's never used.`
`168`	`169`	`/// <summary>`
`169`	`170`	`/// Serializes the values.`
`170`	`171`	`/// </summary>`
`@@ -191,6 +192,7 @@ public BsonArray SerializeValues(IEnumerable values)`
`191`	`192`	`}`
`192`	`193`	`}`
`193`	`194`
	`195`	`+ //DOMAIN-API This method should be probably removed, it's never used.`
`194`	`196`	`/// <summary>`
`195`	`197`	`/// Creates a new BsonSerializationInfo object using the elementName provided and copying all other attributes.`
`196`	`198`	`/// </summary>`