Fix references code lens to include imports as references

When finding references for an exported symbol, the import specifier
(e.g., `abc` in `import { abc } from "./abc"`) should be counted as
a reference to the export. This change:

1. Adds the import location as a reference to the export symbol in
   searchForImportsOfExport for non-aliased imports.

2. Skips duplicate addition of import specifiers when the search
   is coming from an export context, since they're already added
   by the explicit addRef call.

Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>

Author: Copilot

internal/ls/findallreferences.go

@@ -1910,6 +1910,12 @@ func (state *refState) getReferencesAtLocation(sourceFile *ast.SourceFile, posit
 		return
 	}
 
+	// For non-aliased imports like `import { foo }`, skip when coming from an export search,
+	// as these are already added in searchForImportsOfExport.
+	if parent.Kind == ast.KindImportSpecifier && parent.PropertyName() == nil && parent.Name() == referenceLocation && search.comingFrom == ImpExpKindExport {
+		return
+	}
+
 	if parent.Kind == ast.KindExportSpecifier {
 		state.getReferencesAtExportSpecifier(referenceLocation, referenceSymbol, parent.AsExportSpecifier(), search, addReferencesHere, false /*alwaysGetReferences*/)
 		return
@@ -2133,6 +2139,14 @@ func (state *refState) searchForImportsOfExport(exportLocation *ast.Node, export
 
 	// For each import, find all references to that import in its source file.
 	for _, i := range r.importSearches {
+		// For `import { abc }` (no alias), add the import as a reference to the export symbol.
+		// For `import { foo as bar }`, `foo` is already added via singleReferences above,
+		// and `bar` is just a local alias, not a reference to the export.
+		if ast.IsImportSpecifier(i.importLocation.Parent) && i.importLocation.Parent.PropertyName() == nil {
+			addRef := state.referenceAdder(exportSymbol)
+			addRef(i.importLocation, entryKindNode)
+		}
+		// Then search for uses of the imported symbol in the file
 		state.getReferencesInSourceFile(ast.GetSourceFileOfNode(i.importLocation), state.createSearch(i.importLocation, i.importSymbol, ImpExpKindExport, "", nil), true /*addReferencesHere*/)
 	}
 

testdata/baselines/reference/fourslash/codeLenses/codeLensFunctionsAndConstants01.baseline.jsonc

@@ -1,7 +1,7 @@
 // === Code Lenses ===
 // === /exports.ts ===
 // let callCount = 0;
-// export function /*CODELENS: 3 references*/foo(n: number): void {
+// export function /*CODELENS: 4 references*/foo(n: number): void {
 //   callCount++;
 //   if (n > 0) {
 // 	[|foo|](n - 1);
@@ -17,7 +17,7 @@
 // 
 
 // === /importer.ts ===
-// import { foo, bar } from "./exports";
+// import { [|foo|], bar } from "./exports";
 // 
 // [|foo|](5);
 // console.log(bar);
@@ -27,7 +27,7 @@
 
 // === Code Lenses ===
 // === /importer.ts ===
-// import { foo, bar } from "./exports";
+// import { foo, [|bar|] } from "./exports";
 // 
 // foo(5);
 // console.log([|bar|]);
@@ -38,5 +38,5 @@
 // 
 // foo(5);
 // 
-// export const /*CODELENS: 1 reference*/bar = 123;
+// export const /*CODELENS: 2 references*/bar = 123;
 // 

testdata/baselines/reference/fourslash/codeLenses/codeLensInterface01.baseline.jsonc

@@ -89,7 +89,7 @@
 
 // === Code Lenses ===
 // === /classPointable.ts ===
-// import { Pointable } from "./pointable";
+// import { [|Pointable|] } from "./pointable";
 // 
 // class Point implements [|Pointable|] {
 //   getX(): number {
@@ -98,7 +98,7 @@
 // --- (line: 7) skipped ---
 
 // === /objectPointable.ts ===
-// import { Pointable } from "./pointable";
+// import { [|Pointable|] } from "./pointable";
 // 
 // let x = 0;
 // let y = 0;
@@ -109,7 +109,7 @@
 // --- (line: 9) skipped ---
 
 // === /pointable.ts ===
-// export interface /*CODELENS: 2 references*/Pointable {
+// export interface /*CODELENS: 4 references*/Pointable {
 //   getX(): number;
 //   getY(): number;
 // }

testdata/baselines/reference/fourslash/codeLenses/codeLensReferencesIncludeImports.baseline.jsonc

@@ -1,4 +1,8 @@
 // === Code Lenses ===
+// === /other.ts ===
+// import { [|abc|] } from "./abc";
+// 
+
 // === /abc.ts ===
-// export function /*CODELENS: 0 references*/abc() { }
+// export function /*CODELENS: 1 reference*/abc() { }
 // 

testdata/baselines/reference/fourslash/documentHighlights/documentHighlights_filesToSearch.baseline.jsonc

@@ -6,4 +6,4 @@
 
 // === documentHighlights ===
 // === /b.ts ===
-// import { /*HIGHLIGHTS*/[|x|] } from "./a";
+// import { /*HIGHLIGHTS*/[|[|x|]|] } from "./a";

testdata/baselines/reference/fourslash/findAllReferences/findAllReferencesNonExistentExportBinding.baseline.jsonc

@@ -1,6 +1,6 @@
 // === findAllReferences ===
 // === /bar.ts ===
-// import { [|Foo|]/*FIND ALL REFS*/ } from "./foo";
+// import { [|[|Foo|]|]/*FIND ALL REFS*/ } from "./foo";
 
 // === /foo.ts ===
 // export { [|Foo|] }

testdata/baselines/reference/fourslash/findAllReferences/findAllReferencesOfConstructor.baseline.jsonc

@@ -14,11 +14,11 @@
 // new D();
 
 // === /b.ts ===
-// import { C } from "./a";
+// import { [|C|] } from "./a";
 // new [|C|]();
 
 // === /c.ts ===
-// import { C } from "./a";
+// import { [|C|] } from "./a";
 // class D extends C {
 //     constructor() {
 //         [|super|]();
@@ -50,11 +50,11 @@
 // new D();
 
 // === /b.ts ===
-// import { C } from "./a";
+// import { [|C|] } from "./a";
 // new [|C|]();
 
 // === /c.ts ===
-// import { C } from "./a";
+// import { [|C|] } from "./a";
 // class D extends C {
 //     constructor() {
 //         [|super|]();
@@ -86,11 +86,11 @@
 // new D();
 
 // === /b.ts ===
-// import { C } from "./a";
+// import { [|C|] } from "./a";
 // new [|C|]();
 
 // === /c.ts ===
-// import { C } from "./a";
+// import { [|C|] } from "./a";
 // class D extends C {
 //     constructor() {
 //         [|super|]();

testdata/baselines/reference/fourslash/findAllReferences/findAllRefsClassExpression2.baseline.jsonc

@@ -13,7 +13,7 @@
 // exports.[|A|] = class {};
 
 // === /b.js ===
-// import { /*FIND ALL REFS*/[|A|] } from "./a";
+// import { /*FIND ALL REFS*/[|[|A|]|] } from "./a";
 // [|A|];
 
 
@@ -23,5 +23,5 @@
 // exports.[|A|] = class {};
 
 // === /b.js ===
-// import { [|A|] } from "./a";
+// import { [|[|A|]|] } from "./a";
 // /*FIND ALL REFS*/[|A|];

testdata/baselines/reference/fourslash/findAllReferences/findAllRefsExportAsNamespace.baseline.jsonc

@@ -13,7 +13,7 @@
 
 // === findAllReferences ===
 // === /b.ts ===
-// import { /*FIND ALL REFS*/[|f|] } from "a";
+// import { /*FIND ALL REFS*/[|[|f|]|] } from "a";
 
 // === /c.ts ===
 // A.[|f|]();

testdata/baselines/reference/fourslash/findAllReferences/findAllRefsExportConstEqualToClass.baseline.jsonc

@@ -14,4 +14,4 @@
 // export const [|D|] = C;
 
 // === /b.ts ===
-// import { /*FIND ALL REFS*/[|D|] } from "./a";
+// import { /*FIND ALL REFS*/[|[|D|]|] } from "./a";