Skip to content

Commit 1c0b4c8

Browse files
authored
Merge pull request #25 from omahs/patch-1
Fix: typos, merging.
2 parents 2b32f10 + 72d8c4c commit 1c0b4c8

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

contribution-guidelines/code-style-and-guidelines/solidity.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ If a function is **not** `O(1)` , the first line of the `@dev` part of the ENSF
2424

2525
#### External Trust
2626

27-
For functions that make an external call with enough gas for re-entry, not `send` or `transfer`, specify **"UN/TRUSTED."** at the end of the `@dev` part of the ENSF comment. This tells readers wether the external call receiver is trusted or not, i.e. the code it executes is controlled.
27+
For functions that make an external call with enough gas for re-entry, not `send` or `transfer`, specify **"UN/TRUSTED."** at the end of the `@dev` part of the ENSF comment. This tells readers whether the external call receiver is trusted or not, i.e. the code it executes is controlled.
2828

2929
{% hint style="danger" %}
3030
Note that specifying a **contract type** for a variable **does not guarantee** that it will reference a contract of that **type** as any address can be coerced into any contract, and vice-versa.
@@ -51,7 +51,7 @@ Traditional back ends do most of the heavy lifting for the front end, because co
5151
Abstractions can be made to make front end developers' lives easier. Our [archon](https://github.com/kleros/archon) does just that for ERC 792 contracts.
5252
{% endhint %}
5353

54-
This and the security risks of smart contracts that interact with other smart contracts with complex and stateful interdependencies requires that we take a unique approach and mindset when developing smart contracts. Here are some general guidelines:
54+
This and the security risks of smart contracts that interact with other smart contracts with complex and stateful interdependencies require that we take a unique approach and mindset when developing smart contracts. Here are some general guidelines:
5555

5656
* If possible, i.e. does not lead to a significant increase in computation, externally called functions should follow this **3-step pattern**:
5757

contribution-guidelines/general-dev.-workflow/task-tracking-and-lifecycle.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ description: Our methodology for keeping track of development work.
1010
See [Git Code Style & Guidelines](../code-style-and-guidelines/git.md) for our message and branch names style and guidelines.
1111
{% endhint %}
1212

13-
We try to keep the number of tools we use to a minimum for simplicity and ease of on-boarding. The new features of Github make it possible to keep most of the project management next to the code, and this is our approach:
13+
We try to keep the number of tools we use to a minimum for simplicity and ease of onboarding. The new features of Github make it possible to keep most of the project management next to the code, and this is our approach:
1414

1515
| Issues | Projects | Milestones |
1616
| ------------------------------------------------------- | -------------------------------------- | ------------------------------------------------------ |

contribution-guidelines/overview.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,6 @@ This site is maintained at [github.com/kleros/CONTRIBUTING.md](https://github.co
4646

4747
The rules in this guide are meant to be followed as much as possible, but should not override common sense.
4848

49-
> The golden rules is that there are no golden rules.
49+
> The golden rule is that there are no golden rules.
5050
>
5151
> \-George Bernard Shaw-

contribution-guidelines/smart-contract-workflow/rab.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ In the context of reviews, audits and bounties, findings have to be pointed out
1919

2020
Note that this is the same risk rating model used by the [Ethereum Bounty Program](https://bounty.ethereum.org/).
2121

22-
In addition to the severity classification, emphasis should be put in writing clear descriptions, adding tests and instructions for facilitating reproduceability and including potential fixes if known.
22+
In addition to the severity classification, emphasis should be put in writing clear descriptions, adding tests and instructions for facilitating reproducibility and including potential fixes if known.
2323

2424
## RAB Pragmas
2525

0 commit comments

Comments
 (0)