Update to go 1.24

[acouvreur]

Related to #3209 (comment)

Change the go version in go.mod to 1.24.5.

After that, gh-iter could be included in another issue.

[gmlewis]

From our README.md:

go-github tracks [Go's version support policy][support-policy] supporting any
minor version of the latest two major releases of Go and the go directive in
go.mod reflects that.
We do our best not to break older versions of Go if we don't have to, but we
don't explicitly test older versions and as of Go 1.23 the go directive in
go.mod declares a hard required _minimum_ version of Go to use with this module
and this _must_ be greater than or equal to the go line of all dependencies so
go-github will require the N-1 major release of Go by default.

So I think that when Go 1.25 is released, we can safely bump our go.mod to 1.24.5, and we can leave this issue open until that time.

[acouvreur]

That makes perfect sense! Thank you!

But if I understand correctly, we're effectively supporting go 1.23 as a minimum, which support iterator, so I could create a pull request and add gh-iter to this repository right now?

[gmlewis]

But if I understand correctly, we're effectively supporting go 1.23 as a minimum, which support iterator, so I could create a pull request and add gh-iter to this repository right now?

The answer is "Yes" if you mean to "add gh-iter to this repo's examples directory," but the answer is "No" if you want to make it a top-level dependency for the entire repo.

We have attempted over the years to keep the external dependency requirements for this repo to be a bare minimum, but welcome examples that show how to use this repo with helpful external packages.

I hope that makes sense.

[acouvreur]

I understand, I don't what to have a dependency on gh-iter, I want to bring the implementation in this repository directly.

No necessarily as-is, new functions could be added to List functions, such as: ListAll which would do what gh-iter is doing behind the scenes.

I can try to submit a pull request for that and see if that would be a good fit.

[gmlewis]

Oh, I see. I think it was a mistake for me to close #3209 - I probably should have simply left it open and will re-open it now if you wish to continue discussion there.

This also relates to:

• Feature Request: Pagination Handlers #2618
• docs: Update readme and examples for updated go-github-ratelimit and introduce go-github-pagination #3504

[gmlewis]

@acouvreur - do you mind if I close this issue and we can continue discussion in #3209?

[acouvreur]

Let's do this!

[gmlewis]

Closing so we can continue discussion in #3209.