C#: Address review comments.

michaelnebel · michaelnebel · commit af5622a60e8f · 2025-10-21T13:03:53.000+02:00
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Extractor/CompilerVersion.cs b/csharp/extractor/Semmle.Extraction.CSharp/Extractor/CompilerVersion.cs
@@ -75,7 +75,7 @@ public CompilerVersion(Options options)
                 }
 
                 // If csc is specified as compiler name, then attempt to read the version information from csc.dll
-                var compilerBinaryName = SpecifiedCompiler.EndsWith("csc") ? $"{SpecifiedCompiler}.dll" : SpecifiedCompiler;
+                var compilerBinaryName = Path.GetFileName(SpecifiedCompiler) == "csc" ? $"{SpecifiedCompiler}.dll" : SpecifiedCompiler;
                 var versionInfo = FileVersionInfo.GetVersionInfo(compilerBinaryName);
                 if (!knownCompilerNames.TryGetValue(versionInfo.OriginalFilename ?? string.Empty, out var vendor))
                 {

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ public CompilerVersion(Options options)`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`// If csc is specified as compiler name, then attempt to read the version information from csc.dll`
`78`		`- var compilerBinaryName = SpecifiedCompiler.EndsWith("csc") ? $"{SpecifiedCompiler}.dll" : SpecifiedCompiler;`
	`78`	`+ var compilerBinaryName = Path.GetFileName(SpecifiedCompiler) == "csc" ? $"{SpecifiedCompiler}.dll" : SpecifiedCompiler;`
`79`	`79`	`var versionInfo = FileVersionInfo.GetVersionInfo(compilerBinaryName);`
`80`	`80`	`if (!knownCompilerNames.TryGetValue(versionInfo.OriginalFilename ?? string.Empty, out var vendor))`
`81`	`81`	`{`