C#: Use StringBuilder for feed arguments in GetRestoreArgs

mbg · mbg · commit 284f612965ed · 2025-03-14T14:06:48.000Z
diff --git a/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/DotNet.cs b/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/DotNet.cs
@@ -2,7 +2,7 @@
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;
-
+using System.Text;
 using Newtonsoft.Json.Linq;
 
 using Semmle.Util;
@@ -71,10 +71,13 @@ private string GetRestoreArgs(RestoreSettings restoreSettings)
             // the configuration file(s).
             if (restoreSettings.Sources != null)
             {
+                var feedArgs = new StringBuilder();
                 foreach (string source in restoreSettings.Sources)
                 {
-                    args += $" -s {source}";
+                    feedArgs.Append($" -s {source}");
                 }
+
+                args += feedArgs.ToString();
             }
 
             if (restoreSettings.ForceReevaluation)

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`	`using System.Collections.Generic;`
`3`	`3`	`using System.IO;`
`4`	`4`	`using System.Linq;`
`5`		`-`
	`5`	`+using System.Text;`
`6`	`6`	`using Newtonsoft.Json.Linq;`
`7`	`7`
`8`	`8`	`using Semmle.Util;`
`@@ -71,10 +71,13 @@ private string GetRestoreArgs(RestoreSettings restoreSettings)`
`71`	`71`	`// the configuration file(s).`
`72`	`72`	`if (restoreSettings.Sources != null)`
`73`	`73`	`{`
	`74`	`+ var feedArgs = new StringBuilder();`
`74`	`75`	`foreach (string source in restoreSettings.Sources)`
`75`	`76`	`{`
`76`		`- args += $" -s {source}";`
	`77`	`+ feedArgs.Append($" -s {source}");`
`77`	`78`	`}`
	`79`	`+`
	`80`	`+ args += feedArgs.ToString();`
`78`	`81`	`}`
`79`	`82`
`80`	`83`	`if (restoreSettings.ForceReevaluation)`