minNumberInOrder and maxNumberInOrder seem to not be respected

[netbrothers-tr]

Bug Report

Current Behavior

If minNumberInOrder and maxNumberInOrder in a product are set, you are still able to put less than minNumberInOrder and more than maxNumberInOrder items into your cart.

Expected behavior/output

I would expect that the default template (Resources/Private/Partials/Product/CartForm.html) would consider those values and set a min and a max attribute on the input element for the item quantity.

Environment

• TYPO3 version(s): 13.4.18
• cart version: 11.4.14
• cart-products version: 7.1.0
• Is your TYPO3 installation set up with Composer (Composer Mode): yes
• OS: Ubuntu Linux

Possible Solution

If that's really a bug and I'm not overlooking anything, fixing this opens up the opportunity to add another property (named "bundleSize" for instance) which would control a step size. As an example: you could offer bananas and require a minimum of 5, a maximum of 25 items in an order and only allow amounts divisible by 5 (5, 10, 15, 20, 25).

[extcode]

This behaviour is currently implemented. If the minimum order quantity for a product is not reached or the maximum order quantity is exceeded, the selected quantity is still added to the shopping cart. However, a note is then displayed on the product in the standard template in the shopping cart and the order cannot be submitted.

It should be possible to adjust the behaviour when adding a product to the shopping cart to indicate that the minimum quantity has not been reached. It is more problematic to handle the behaviour ‘correctly’ when the maximum quantity is reached or exceeded. What happens then? Is nothing added to the shopping cart, is the quantity in the shopping cart filled up to the maximum order quantity, or is everything added that the user wanted to place in the shopping cart at that moment?

The whole thing becomes even more complicated if you have a certain number of products in your shopping cart and then add another product, exceeding the maximum order quantity.

Of course, this can be configured, but it can quickly become very complicated, especially since I know of a project where the maximum order quantity refers to the product and not to the product variant. In this project, you can add the product to your shopping basket 12 times (in abstract terms). It doesn't matter whether it's variant A or variant B. The total number must not exceed 12. In my opinion, it is easier to let the user decide in the shopping basket how many of variant A or B they want to add to their shopping cart.

If we can get another method well defined in TYPO3 Slack and someone pays for the feature, I would implement it in extcode/cart. It is important that the implementation also includes the corresponding tests, because I cannot guarantee that I will be able to manually test this new behaviour with every new release.

However, if no error is displayed in the shopping cart and the order can still be completed, then it is indeed a bug. Is that correct?

[netbrothers-tr]

Thank you, @extcode, for providing this open source extension and in particular for your swift response! I now can see the implications of enforcing this while adding to the cart.

I can confirm, that submitting an order is denied if the quantity requirement of a product is not met (the submit button is not rendered). However, no error message is displayed indicating the problem to the buyer. If indeed it should be visible, I'd be thankful for any hint on how to debug this.