Skip to content

Larger code restructuring to keep it more approachable #10

@mindreframer

Description

@mindreframer

Hey @dominicletz , thanks for this project!

After fighting with Tauri (v2) and Electron, I'm willing to accept less polish in features for the beloved experience of using Elixir even for desktop apps! Having a proper REPL and all the great Elixir tooling is sooo nice!

I hit a bug today when integrating Destop.Deployment package into my app... And when I looked into the code, I found it somewhat hard to follow, to be honest. And since I want to use Elixir on the desktop for longer term, I decided to clean it up. As you can imagine, it became a larger change.

Hence I will not open a PR right now, so you do not get a heart attack (I know the feeling). My changes are here:

Please take a look and see if you like it. I will be using my fork, so there is no rush for you to do anything. It is mostly the same code, with more structure, more smaller modules, simpler conventions and a nice way to organize a sequence of actions in a conventional way.

I also fixed the issue with dynamic libraries for OSX (where the install name does not match the actual path). It works now with the default SQLITE package, no need to use your fork (at least on OSX). - https://github.com/maxohq/desktop-deployment/blob/feat/mybranch/issues/ci-path-on-osx-deps.txt

Anyways, since I hope to use this package in the future, I'm willing to contribute some polish and smaller fixes to it, that I encounter in my work.

Have a great weekend!
Roman

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions