From 7e72db5557362ad927ab8793027799e9e2cee91d Mon Sep 17 00:00:00 2001 From: Neha Burnwal Date: Fri, 19 Dec 2025 11:27:47 +0530 Subject: [PATCH] Caught the exception when a version is malformed in target file --- .../src/org/eclipse/pde/internal/ui/PDEUIMessages.java | 2 ++ .../internal/ui/editor/targetdefinition/TargetEditor.java | 7 +++++++ .../org/eclipse/pde/internal/ui/pderesources.properties | 1 + 3 files changed, 10 insertions(+) diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/PDEUIMessages.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/PDEUIMessages.java index 2cd9973b826..ceb5e6ade8e 100644 --- a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/PDEUIMessages.java +++ b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/PDEUIMessages.java @@ -3212,6 +3212,8 @@ public class PDEUIMessages extends NLS { public static String TargetEditor_6; + public static String TargetEditor_7; + public static String FeatureImportWizardPage_importHasInvalid; public static String ProductInfoSection_plugins; diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/targetdefinition/TargetEditor.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/targetdefinition/TargetEditor.java index 137cb76be06..c922864785a 100644 --- a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/targetdefinition/TargetEditor.java +++ b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/targetdefinition/TargetEditor.java @@ -195,6 +195,10 @@ protected void pageChange(int newPageIndex) { setActivePage(fSourceTabIndex); CoreException ce = new CoreException(Status.error(e.getMessage(), e)); showError(PDEUIMessages.TargetEditor_5, ce); + } catch (IllegalArgumentException e) { + setActivePage(fSourceTabIndex); + CoreException ce = new CoreException(Status.error(e.getMessage(), e)); + showError(PDEUIMessages.TargetEditor_7, ce); } } @@ -560,6 +564,9 @@ private ITargetDefinition loadTargetDefinition() throws CoreException { } catch (CoreException e) { fTarget = service.newTarget(); throw e; + } catch (IllegalArgumentException e) { + fTarget = service.newTarget(); + throw new CoreException(Status.error(e.getMessage(), e)); } PlatformUI.getWorkbench().getDisplay().asyncExec( () -> TargetEditor.this.getTargetChangedListener().contentsChanged(fTarget, this, true, false)); diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties index e4b64b907eb..cf0a5db436b 100644 --- a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties +++ b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties @@ -1994,6 +1994,7 @@ TargetEditor_3=Unable to perform save TargetEditor_4=Target Editor TargetEditor_5=Unable to load target definition model. Fix the target definition model in Source View. TargetEditor_6=The editor input ''{0}'' is not supported. +TargetEditor_7=Unable to parse the IU version TargetCreationPage_0=Initialize the target definition with: TargetCreationPage_1=Nothing: Start &with an empty target definition TargetCreationPage_2=&Default: Default target for the running platform