Test results: FreeBSD-10.2

[infracaninophile]

Hi,

I'm getting the following on FreeBSD-10.2 using version b2873cf:

..........x............x.....x......x....x.......xx......................................x...x....x.x.....x.x..........

In test "Directory notifications":
    failed: receive IN_MOVED_FROM event on moving file from directory to another location within the same mount point
    failed: receive IN_MOVED_TO event on moving file to directory from another location within the same mount point

In test "Open/close notifications":
    failed: receive IN_OPEN on cat
    failed: receive IN_CLOSE_NOWRITE on cat
    failed: receive IN_OPEN on ls
    failed: receive IN_CLOSE_NOWRITE on ls
    failed: receive IN_OPEN on modify
    failed: receive IN_CLOSE_WRITE on modify

In test "Symbolic links":
    failed: Start watch successfully on a symlink file with IN_DONT_FOLLOW
    failed: Receive IN_ATTRIB after touching symlink itself
    failed: Receive IN_MOVE_SELF after moving the symlink
    failed: Receive IN_DELETE_SELF after removing the symlink

In test "Failures":
    failed: watch id is -1, errno set to EACCES when starting watching a file without read access

--------------------
     Run: 119
  Passed: 106
  Failed: 13

# uname -a 
FreeBSD stingray.adestra.com 10.2-RELEASE FreeBSD 10.2-RELEASE #0 r286666: Wed Aug 12 15:26:37 UTC 2015     root@releng1.nyi.freebsd.org:/usr/obj/usr/src/sys/GENERIC  amd64

Configure command line:

$ ./configure --prefix=/usr/local --localstatedir=/var --mandir=/usr/local/man --infodir=/usr/local/info/ --build=amd64-portbld-freebsd10.2

Aside from the expected IN_OPEN, IN_CLOSE_WRITE and IN_CLOSE_NOWRITE failures what am I missing here to get all the tests passing?

[wulf7]

Aside from the expected IN_OPEN, IN_CLOSE_WRITE and IN_CLOSE_NOWRITE failures what am I missing here to get all the tests passing?

Kernel should be patched to pass all the tests as it reqired some kqueue and open() extensions. These patches can be found in "patches" subdirectory and should be applied to 6-month old CURRENT. They require trivial updating to be applied to 10.2 or fresh CURRENT
The result you got is expected for tests running on stock kernel except the last error: "watch id is -1, errno set to EACCES when starting watching a file without read access". But I cant reproduce this error in 10.2 running in virtualbox

[wulf7]

except the last error: "watch id is -1, errno set to EACCES when starting watching a file without read access". But I cant reproduce this error in 10.2 running in virtualbox

Are you tried to run tests as root?

[infracaninophile]

On 09/15/15 11:58, Vladimir Kondratiev wrote:

Are you tried to run tests as root?

Yes, exactly.

Cheers,

Matthew

[wulf7]

Are you tried to run tests as root?

Yes, exactly.

Tried this on EL6.4 just now an found that Linux root is able to open files with 000 permissions for watching also. So this issue can be considered as testsuite bug. Could you run tests as ordinary user?

P.S. Thanks for reporting this.

[infracaninophile]

On 09/15/15 12:43, Vladimir Kondratiev wrote:

Are you tried to run tests as root?

Yes, exactly.

Tried this on EL6.4 just now an found that Linux root is able to open files with 000 permissions for watching also. So this issue can be considered as testsuite bug. Could you run tests as ordinary user?

P.S. Thanks for reporting this.

If I run the tests as an ordinary user the EACCES failure doesn't occur.

Running test suite...
...................xx..................xx............xx..................................x...x....x.x.....x.x..........

In test "Directory notifications":
    failed: receive IN_MOVED_FROM event on moving file from directory to
another location within the same mount point
    failed: receive IN_MOVED_TO event on moving file to directory from
another location within the same mount point

In test "Open/close notifications":
    failed: receive IN_OPEN on cat
    failed: receive IN_CLOSE_NOWRITE on cat
    failed: receive IN_OPEN on ls
    failed: receive IN_CLOSE_NOWRITE on ls
    failed: receive IN_OPEN on modify
    failed: receive IN_CLOSE_WRITE on modify

In test "Symbolic links":
    failed: Start watch successfully on a symlink file with IN_DONT_FOLLOW
    failed: Receive IN_ATTRIB after touching symlink itself
    failed: Receive IN_MOVE_SELF after moving the symlink
    failed: Receive IN_DELETE_SELF after removing the symlink

--------------------
     Run: 119
  Passed: 107
  Failed: 12

PS. I'm just about to submit a PR to get the FreeBSD ports updated to
the latest version of libinotify.

Cheers,

Matthew

[wulf7]

There are no unexpected failures now.

P.S. Thanks again for report and plz dont close this issue as it reveals a false-positive in test suite