From 2b54f83ad803a68e3eae4b6b1a40bd9c47c8296e Mon Sep 17 00:00:00 2001 From: Goooler Date: Wed, 18 Sep 2024 19:10:37 +0800 Subject: [PATCH] Add Java 23 into test matrix --- .github/workflows/ci.yml | 2 +- .../diffplug/gradle/spotless/GradleIntegrationHarness.java | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f7cbb3377c..e5de52b4d9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -41,7 +41,7 @@ jobs: matrix: kind: [maven, gradle] # Test on the latest Java version once Gradle & Maven support it. - jre: [11, 17, 21, 22] + jre: [11, 17, 21, 23] os: [ubuntu-latest] include: # test windows at the diagonals of the above matrix diff --git a/plugin-gradle/src/test/java/com/diffplug/gradle/spotless/GradleIntegrationHarness.java b/plugin-gradle/src/test/java/com/diffplug/gradle/spotless/GradleIntegrationHarness.java index 0084893274..3621c2a0f6 100644 --- a/plugin-gradle/src/test/java/com/diffplug/gradle/spotless/GradleIntegrationHarness.java +++ b/plugin-gradle/src/test/java/com/diffplug/gradle/spotless/GradleIntegrationHarness.java @@ -54,8 +54,11 @@ public enum GradleVersionSupport { GradleVersionSupport(String version) { String minVersionForRunningJRE; switch (Jvm.version()) { - case 23: + case 24: // TODO: https://docs.gradle.org/current/userguide/compatibility.html + case 23: + minVersionForRunningJRE = "8.10"; + break; case 22: minVersionForRunningJRE = "8.8"; break;