global default_timeout is not being respected

[adduc]

Deployer Version

v7.5.12

Target OS

Fedora 43

Which PHP version are you using?

PHP 8.4

Content of deploy.php or deploy.yaml

<?php

declare(strict_types=1);

namespace Deployer;

require 'recipe/common.php';

// Config

// if the PHP configuration variables_order excludes e, $_ENV won't be
// populated, so we check if it's empty and then use getenv() to fill it
if (empty($_ENV)) {
    $_ENV = getenv();
}

set('repository', '');

add('shared_files', []);
add('shared_dirs', []);
add('writable_dirs', []);

set('shell', '/bin/sh');

set('default_timeout', null);

printf(
    "[pid:%d] Global default timeout: %s\n",
    getmypid(),
    var_export(get('default_timeout', 300), true)
);

// Hosts

host('localhost')
    ->set('deploy_path', '/tmp/deploy');

// Hooks

after('deploy:failed', 'deploy:unlock');

// Overrides

task('deploy:update_code')->setCallback(static function () {
    printf(
        "[pid:%d] task default timeout: %s\n",
        getmypid(),
        var_export(get('default_timeout', 300), true)
    );
});

Steps to reproduce

When running tasks on a remote host, the global default_timeout of null is ignored, causing the default_timeout to be set to the default of 300.

This appears to be a bug, or at least a discrepancy between the documented intention of the default_timeout and the actual behavior.

This behavior appears to exist in both v7.x and v8.x (master).

./vendor/bin/dep deploy:update_code
[pid:646174] Global default timeout: NULL
task deploy:update_code
[pid:646181] Global default timeout: NULL
[pid:646181] task default timeout: 300

Related

I couldn't find any discussions that appear to replicate this behavior, but there was an issue that reported this bug as early as 2023.

• How to disable task timeout? #2735: mentions passing null for run()'s $timeout parameter causes it to be ignored. Possibly related?
• Disabling default_timeout for run/runLocally has no effect #3447: issue mentions disabling default_timeout has no effect
• Disabling the run timeout with null doesn't work anymore #3074: mentions disabling run timeout with null; I think this might be the same as How to disable task timeout? #2735 and pertains to run()'s $timeout

[antonmedv]

I see. Deployer treats null as unset. Lets change behavior to INF meaning disabled? Can you open a PR for master branch?