From 2b21335da11b3f9fe436d58ca2231ee3e4dba73c Mon Sep 17 00:00:00 2001 From: Joan Perals Tresserra Date: Fri, 20 Dec 2024 09:45:33 +0100 Subject: [PATCH 1/2] fix: Handle undefined content --- src/code-view/__tests__/code-view.test.tsx | 6 ++++++ src/code-view/internal.tsx | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/code-view/__tests__/code-view.test.tsx b/src/code-view/__tests__/code-view.test.tsx index 0f2bd8e..43d0173 100644 --- a/src/code-view/__tests__/code-view.test.tsx +++ b/src/code-view/__tests__/code-view.test.tsx @@ -103,4 +103,10 @@ describe("CodeView", () => { const element = wrapper!.findContent().getElement(); expect(element.outerHTML).toContain("code-line-wrap"); }); + + test("handles undefined content", () => { + render(); + const wrapper = createWrapper().findCodeView()!; + expect(wrapper!.findContent().getElement().textContent).toBe("\n"); + }); }); diff --git a/src/code-view/internal.tsx b/src/code-view/internal.tsx index 34507ce..f7d2698 100644 --- a/src/code-view/internal.tsx +++ b/src/code-view/internal.tsx @@ -32,7 +32,7 @@ const textHighlight = (code: string) => { }; export function InternalCodeView({ - content, + content = "", actions, lineNumbers, wrapLines, From 476540b268989f256d2682adedcfd9ad4f5da3b1 Mon Sep 17 00:00:00 2001 From: Joan Perals Tresserra Date: Fri, 20 Dec 2024 09:53:49 +0100 Subject: [PATCH 2/2] Refine test --- src/code-view/__tests__/code-view.test.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/code-view/__tests__/code-view.test.tsx b/src/code-view/__tests__/code-view.test.tsx index 43d0173..52a4b47 100644 --- a/src/code-view/__tests__/code-view.test.tsx +++ b/src/code-view/__tests__/code-view.test.tsx @@ -3,7 +3,7 @@ import { cleanup, getByText, render } from "@testing-library/react"; import { afterEach, describe, expect, test } from "vitest"; -import CodeView from "../../../lib/components/code-view"; +import CodeView, { CodeViewProps } from "../../../lib/components/code-view"; import typescriptHighlightRules from "../../../lib/components/code-view/highlight/typescript"; import createWrapper from "../../../lib/components/test-utils/dom"; @@ -105,7 +105,8 @@ describe("CodeView", () => { }); test("handles undefined content", () => { - render(); + const props = {} as CodeViewProps; + render(); const wrapper = createWrapper().findCodeView()!; expect(wrapper!.findContent().getElement().textContent).toBe("\n"); });