From 6fca4587360084b3a839f6d1ef7d1ef15ec28aa5 Mon Sep 17 00:00:00 2001 From: Gaelle Date: Tue, 23 Jul 2024 09:17:01 +0200 Subject: [PATCH 1/4] fix project-card width --- .../specific/projects/project-card/ProjectCard.scss | 3 +-- .../project-card-model-preview/ProjectCardModelPreview.scss | 4 ++++ .../project-card-model-preview/ProjectCardModelPreview.vue | 1 - .../projects/project-creation-card/ProjectCreationCard.scss | 1 - src/views/space-board/SpaceBoard.vue | 1 + 5 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/components/specific/projects/project-card/ProjectCard.scss b/src/components/specific/projects/project-card/ProjectCard.scss index 8bd246c79..590c157c7 100644 --- a/src/components/specific/projects/project-card/ProjectCard.scss +++ b/src/components/specific/projects/project-card/ProjectCard.scss @@ -2,7 +2,6 @@ .project-card { min-width: $card-width; - width: $card-width; height: $card-height; .bimdata-card { @@ -24,7 +23,7 @@ position: absolute; z-index: 1; width: 4px; - height: $card-height; + height: 100%; &--new { background-color: var(--color-primary); diff --git a/src/components/specific/projects/project-card/project-card-model-preview/ProjectCardModelPreview.scss b/src/components/specific/projects/project-card/project-card-model-preview/ProjectCardModelPreview.scss index 8128646aa..07b09393a 100644 --- a/src/components/specific/projects/project-card/project-card-model-preview/ProjectCardModelPreview.scss +++ b/src/components/specific/projects/project-card/project-card-model-preview/ProjectCardModelPreview.scss @@ -15,4 +15,8 @@ margin: 0 calc((100% - 100px) / 2); margin-top: 16px; } + // @TODO - Remove this and fix width into bcf-components lib for the component to also accept percentages + .preview-3d { + width: 100% !important; + } } diff --git a/src/components/specific/projects/project-card/project-card-model-preview/ProjectCardModelPreview.vue b/src/components/specific/projects/project-card/project-card-model-preview/ProjectCardModelPreview.vue index f46d99de3..0fe653553 100644 --- a/src/components/specific/projects/project-card/project-card-model-preview/ProjectCardModelPreview.vue +++ b/src/components/specific/projects/project-card/project-card-model-preview/ProjectCardModelPreview.vue @@ -13,7 +13,6 @@ :type="!image.url || image.type === MODEL_TYPE.IFC ? '3d' : '2d'" :previewUrl="image.url" defaultUrl="/static/default-model-preview.png" - :width="320" :height="205" /> diff --git a/src/components/specific/projects/project-creation-card/ProjectCreationCard.scss b/src/components/specific/projects/project-creation-card/ProjectCreationCard.scss index 3ff667c46..4a49b0a05 100644 --- a/src/components/specific/projects/project-creation-card/ProjectCreationCard.scss +++ b/src/components/specific/projects/project-creation-card/ProjectCreationCard.scss @@ -5,7 +5,6 @@ display: flex; justify-content: center; align-items: center; - width: $card-width; height: $card-height; box-shadow: var(--box-shadow); background-color: var(--color-white); diff --git a/src/views/space-board/SpaceBoard.vue b/src/views/space-board/SpaceBoard.vue index 89e706138..ada033e2f 100644 --- a/src/views/space-board/SpaceBoard.vue +++ b/src/views/space-board/SpaceBoard.vue @@ -66,6 +66,7 @@ itemWidth="320px" rowGap="36px" columnGap="36px" + :isRepeatFit="true" :style="{ justifyContent: isMD ? 'center' : '' }" > From 427200c58b666f1f3c3ad37d031f67adba966a0f Mon Sep 17 00:00:00 2001 From: Gaelle Date: Tue, 23 Jul 2024 09:21:15 +0200 Subject: [PATCH 2/4] fix favorite-badge for project card --- src/components/specific/projects/project-card/ProjectCard.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/specific/projects/project-card/ProjectCard.scss b/src/components/specific/projects/project-card/ProjectCard.scss index 590c157c7..6dfdafdd2 100644 --- a/src/components/specific/projects/project-card/ProjectCard.scss +++ b/src/components/specific/projects/project-card/ProjectCard.scss @@ -46,7 +46,7 @@ position: absolute; z-index: 2; top: 0; - left: calc($card-width - 66px); + right: 15%; } .project-status-badge { From 5e78928a82259b440f8273c1a79cfa8b0b1b0c1d Mon Sep 17 00:00:00 2001 From: Gaelle Date: Tue, 23 Jul 2024 09:41:44 +0200 Subject: [PATCH 3/4] fix placeholder width --- src/components/specific/projects/project-card/ProjectCard.scss | 2 +- .../project-card-model-preview/ProjectCardModelPreview.scss | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/components/specific/projects/project-card/ProjectCard.scss b/src/components/specific/projects/project-card/ProjectCard.scss index 6dfdafdd2..885276fec 100644 --- a/src/components/specific/projects/project-card/ProjectCard.scss +++ b/src/components/specific/projects/project-card/ProjectCard.scss @@ -87,7 +87,7 @@ .project-card-placeholder { min-width: $card-width; - width: $card-width; + width: 100%; height: $card-height; box-shadow: var(--box-shadow); background-color: var(--color-silver-light); diff --git a/src/components/specific/projects/project-card/project-card-model-preview/ProjectCardModelPreview.scss b/src/components/specific/projects/project-card/project-card-model-preview/ProjectCardModelPreview.scss index 07b09393a..719ba5099 100644 --- a/src/components/specific/projects/project-card/project-card-model-preview/ProjectCardModelPreview.scss +++ b/src/components/specific/projects/project-card/project-card-model-preview/ProjectCardModelPreview.scss @@ -16,7 +16,8 @@ margin-top: 16px; } // @TODO - Remove this and fix width into bcf-components lib for the component to also accept percentages - .preview-3d { + .preview-3d, + .preview-2d { width: 100% !important; } } From 1a6653f0592c48ff2ef168e145c42d246df070ea Mon Sep 17 00:00:00 2001 From: Gaelle Date: Tue, 23 Jul 2024 09:53:43 +0200 Subject: [PATCH 4/4] add TODO comment --- .../project-card-model-preview/ProjectCardModelPreview.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/specific/projects/project-card/project-card-model-preview/ProjectCardModelPreview.scss b/src/components/specific/projects/project-card/project-card-model-preview/ProjectCardModelPreview.scss index 719ba5099..63875f1f4 100644 --- a/src/components/specific/projects/project-card/project-card-model-preview/ProjectCardModelPreview.scss +++ b/src/components/specific/projects/project-card/project-card-model-preview/ProjectCardModelPreview.scss @@ -15,7 +15,7 @@ margin: 0 calc((100% - 100px) / 2); margin-top: 16px; } - // @TODO - Remove this and fix width into bcf-components lib for the component to also accept percentages + // @TODO - Remove this and fix width into bimdata-components lib for the component to also accept percentages & fix onMouseMove .preview-3d, .preview-2d { width: 100% !important;