From 15003f287417c46c8f64f4bb3473d3ca68efd53c Mon Sep 17 00:00:00 2001 From: jirehhuang Date: Mon, 29 Dec 2025 09:25:22 -0800 Subject: [PATCH 1/3] test: add failing test for number of verses in Genesis 17 --- tests/counters_test.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/tests/counters_test.py b/tests/counters_test.py index 27bbc543..13597066 100644 --- a/tests/counters_test.py +++ b/tests/counters_test.py @@ -210,3 +210,14 @@ def test_count_verses_string() -> None: # Then the count is correct assert number_of_verses == 1 + 1 + (3 + 1) + + +def test_count_verses_genesis_17() -> None: + # To address https://github.com/avendesora/pythonbible/issues/223 + reference: str = "Genesis 17" + + # Retrieve number of verses in Genesis 17 + number_of_verses: int = bible.count_verses(reference) + + # Genesis 17 should have 27 verses + assert number_of_verses == 27 From 1401734695fbf6cc7f480836a774b4ab516ed4a8 Mon Sep 17 00:00:00 2001 From: jirehhuang Date: Mon, 29 Dec 2025 09:26:02 -0800 Subject: [PATCH 2/3] fix: update verse count in Genesis 17 from 28 to 27 --- pythonbible/verses.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pythonbible/verses.py b/pythonbible/verses.py index a5d796b6..b6043e53 100644 --- a/pythonbible/verses.py +++ b/pythonbible/verses.py @@ -24,7 +24,7 @@ 24, 21, 16, - 28, + 27, 34, 38, 19, From 06c57e0a403693f261eed7a6c38e1607116b2f75 Mon Sep 17 00:00:00 2001 From: jirehhuang Date: Mon, 29 Dec 2025 09:31:43 -0800 Subject: [PATCH 3/3] fix(test): fix type checking for count_verses(str) --- tests/counters_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/counters_test.py b/tests/counters_test.py index 13597066..4492c2ef 100644 --- a/tests/counters_test.py +++ b/tests/counters_test.py @@ -217,7 +217,7 @@ def test_count_verses_genesis_17() -> None: reference: str = "Genesis 17" # Retrieve number of verses in Genesis 17 - number_of_verses: int = bible.count_verses(reference) + number_of_verses: int = bible.count_verses(reference) # type: ignore[arg-type] # Genesis 17 should have 27 verses assert number_of_verses == 27