From 522c2eee1d1f33006bd292627f666f8533559dd1 Mon Sep 17 00:00:00 2001 From: Adam Parish Date: Tue, 29 Apr 2025 12:18:50 -0700 Subject: [PATCH 1/4] fix: iframe name --- index.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/index.js b/index.js index ad03ccf..f7afdd4 100644 --- a/index.js +++ b/index.js @@ -40,6 +40,9 @@ let atomicSDK = { let iframeElement = document.createElement('iframe') iframeElement.setAttribute('allow', 'web-share') + const productType = config.product || 'Transact' + iframeElement.setAttribute('title', `Atomic ${productType} Interface`) + iframeElement.setAttribute('aria-label', `Atomic ${productType} Interface`) iframeElement.src = `${origin}/initialize/${btoa( JSON.stringify({ From 37e444bb3b6ca5678b805b51716f6831e2889d32 Mon Sep 17 00:00:00 2001 From: Adam Parish Date: Tue, 29 Apr 2025 12:39:58 -0700 Subject: [PATCH 2/4] fix: test snapshot --- test/__snapshots__/index.spec.js.snap | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/test/__snapshots__/index.spec.js.snap b/test/__snapshots__/index.spec.js.snap index 2eb4748..43c0e06 100644 --- a/test/__snapshots__/index.spec.js.snap +++ b/test/__snapshots__/index.spec.js.snap @@ -6,6 +6,14 @@ exports[`JavaScript SDK should initialize the sdk 1`] = ` "allow", "web-share", ], + [ + "title", + "Atomic Transact Interface", + ], + [ + "aria-label", + "Atomic Transact Interface", + ], ] `; From a11ada08745cd43fad901a765dca2da4a1dc3e29 Mon Sep 17 00:00:00 2001 From: Adam Parish Date: Wed, 30 Apr 2025 14:22:50 -0700 Subject: [PATCH 3/4] fix: add operation --- index.js | 2 +- test/__snapshots__/index.spec.js.snap | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/index.js b/index.js index f7afdd4..fb1c411 100644 --- a/index.js +++ b/index.js @@ -40,7 +40,7 @@ let atomicSDK = { let iframeElement = document.createElement('iframe') iframeElement.setAttribute('allow', 'web-share') - const productType = config.product || 'Transact' + const productType = config.operation || config.product || 'Atomic' iframeElement.setAttribute('title', `Atomic ${productType} Interface`) iframeElement.setAttribute('aria-label', `Atomic ${productType} Interface`) diff --git a/test/__snapshots__/index.spec.js.snap b/test/__snapshots__/index.spec.js.snap index 43c0e06..aad2c12 100644 --- a/test/__snapshots__/index.spec.js.snap +++ b/test/__snapshots__/index.spec.js.snap @@ -8,11 +8,11 @@ exports[`JavaScript SDK should initialize the sdk 1`] = ` ], [ "title", - "Atomic Transact Interface", + "Atomic Atomic Interface", ], [ "aria-label", - "Atomic Transact Interface", + "Atomic Atomic Interface", ], ] `; From ff7f18dd421a12441d2d39a64b40798fa3c68865 Mon Sep 17 00:00:00 2001 From: Adam Parish Date: Mon, 9 Jun 2025 15:43:04 -0700 Subject: [PATCH 4/4] fix: update iframe title and aria-label --- index.js | 4 ++-- package-lock.json | 4 ++-- test/__snapshots__/index.spec.js.snap | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/index.js b/index.js index fb1c411..4e5c4bd 100644 --- a/index.js +++ b/index.js @@ -41,8 +41,8 @@ let atomicSDK = { let iframeElement = document.createElement('iframe') iframeElement.setAttribute('allow', 'web-share') const productType = config.operation || config.product || 'Atomic' - iframeElement.setAttribute('title', `Atomic ${productType} Interface`) - iframeElement.setAttribute('aria-label', `Atomic ${productType} Interface`) + iframeElement.setAttribute('title', `${productType} Interface`) + iframeElement.setAttribute('aria-label', `${productType} Interface`) iframeElement.src = `${origin}/initialize/${btoa( JSON.stringify({ diff --git a/package-lock.json b/package-lock.json index ea794b2..769fbaa 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@atomicfi/transact-javascript", - "version": "3.0.4", + "version": "3.0.6", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@atomicfi/transact-javascript", - "version": "3.0.4", + "version": "3.0.6", "license": "ISC", "devDependencies": { "jest": "^29.7.0", diff --git a/test/__snapshots__/index.spec.js.snap b/test/__snapshots__/index.spec.js.snap index aad2c12..6711bed 100644 --- a/test/__snapshots__/index.spec.js.snap +++ b/test/__snapshots__/index.spec.js.snap @@ -8,11 +8,11 @@ exports[`JavaScript SDK should initialize the sdk 1`] = ` ], [ "title", - "Atomic Atomic Interface", + "Atomic Interface", ], [ "aria-label", - "Atomic Atomic Interface", + "Atomic Interface", ], ] `;