VEEAM Backup integration - CloudStack 4.20

[miko-meos]

problem

Hello,

i have problems with VEEAM integration. Error log is:

2025-02-27 10:49:09,483 ERROR [o.a.c.b.v.VeeamClient] (BackgroundTaskPollManager-1:[ctx-73af4556]) (logid:0a2a6480) Failed to process response to get VM restore points via Veeam B&R API due to: com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "SqlInfo" (class org.apache.cloudstack.backup.veeam.api.VmRestorePoint), not marked as ignorable (11 known properties: "UID", "HierarchyObjRef", "VmName", "VmDisplayName", "CreationTimeUTC", "Links", "Type", "Href", "Algorithm", "Name", "PointType"])
at [Source: (org.apache.http.conn.EofSensorInputStream); line: 1, column: 64970] (through reference chain: org.apache.cloudstack.backup.veeam.api.VmRestorePoints["VmRestorePoint"]->java.util.ArrayList[36]->org.apache.cloudstack.backup.veeam.api.VmRestorePoint["SqlInfo"])
at com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException.from(UnrecognizedPropertyException.java:61)
at com.fasterxml.jackson.databind.DeserializationContext.handleUnknownProperty(DeserializationContext.java:1127)
at com.fasterxml.jackson.databind.deser.std.StdDeserializer.handleUnknownProperty(StdDeserializer.java:2023)
at com.fasterxml.jackson.databind.deser.BeanDeserializerBase.handleUnknownProperty(BeanDeserializerBase.java:1700)
at com.fasterxml.jackson.databind.deser.BeanDeserializerBase.handleUnknownVanilla(BeanDeserializerBase.java:1678)
at com.fasterxml.jackson.databind.deser.BeanDeserializer.vanillaDeserialize(BeanDeserializer.java:319)
at com.fasterxml.jackson.databind.deser.BeanDeserializer.deserialize(BeanDeserializer.java:176)
at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer._deserializeFromArray(CollectionDeserializer.java:355)
at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer.deserialize(CollectionDeserializer.java:244)
at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer.deserialize(CollectionDeserializer.java:28)
at com.fasterxml.jackson.databind.deser.impl.FieldProperty.deserializeAndSet(FieldProperty.java:138)
at com.fasterxml.jackson.databind.deser.BeanDeserializer.vanillaDeserialize(BeanDeserializer.java:313)
at com.fasterxml.jackson.databind.deser.BeanDeserializer.deserialize(BeanDeserializer.java:176)
at com.fasterxml.jackson.dataformat.xml.deser.WrapperHandlingDeserializer.deserialize(WrapperHandlingDeserializer.java:122)
at com.fasterxml.jackson.dataformat.xml.deser.XmlDeserializationContext.readRootValue(XmlDeserializationContext.java:91)
at com.fasterxml.jackson.databind.ObjectMapper._readMapAndClose(ObjectMapper.java:4674)
at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3666)
at org.apache.cloudstack.backup.veeam.VeeamClient.processHttpResponseForVmRestorePoints(VeeamClient.java:889)
at org.apache.cloudstack.backup.veeam.VeeamClient.listVmRestorePointsViaVeeamAPI(VeeamClient.java:877)
at org.apache.cloudstack.backup.veeam.VeeamClient.listRestorePoints(VeeamClient.java:867)
at org.apache.cloudstack.backup.VeeamBackupProvider.listRestorePoints(VeeamBackupProvider.java:327)
at org.apache.cloudstack.backup.VeeamBackupProvider.syncBackups(VeeamBackupProvider.java:349)
at org.apache.cloudstack.backup.BackupManagerImpl$BackupSyncTask.tryToSyncVMBackups(BackupManagerImpl.java:1261)
at org.apache.cloudstack.backup.BackupManagerImpl$BackupSyncTask.syncBackupMetrics(BackupManagerImpl.java:1251)
at org.apache.cloudstack.backup.BackupManagerImpl$BackupSyncTask.runInContext(BackupManagerImpl.java:1239)
at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
at java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305)
at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:840)
2025-02-27 10:49:09,486 DEBUG [o.a.c.b.VeeamBackupProvider] (BackgroundTaskPollManager-1:[ctx-73af4556]) (logid:0a2a6480) Can't find any restore point to VM: [uuid: f458edf4-1c5e-4cc4-be35-fe96f7e9427e, name: netboxext].

versions

CloudStack 4.20
Veeam 12.2

The steps to reproduce the bug

1. Assign VM to backup
2. Start Backup

What to do about it?

The backup is working when we are looking at VEEAM management console. Job is created and executed with SUCCES

[boring-cyborg]

Thanks for opening your first issue here! Be sure to follow the issue template!

[DaanHoogland]

@winterhazel @weizhouapache , does this look like it is fixed in 4.20-head or main?

[weizhouapache]

@winterhazel @weizhouapache , does this look like it is fixed in 4.20-head or main?

@DaanHoogland
I do not think so

SqlInfo might be a new property of vm restore point, introduced in recent veeam releases

I did not find it in the response body of Veeam 12.0 API
https://helpcenter.veeam.com/docs/backup/em_rest/get_vmrestorepoints_id.html?ver=120

[winterhazel]

SqlInfo might be a new property of vm restore point, introduced in recent veeam releases

It may be good to add a objectMapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false); to ignore these on org.apache.cloudstack.backup.veeam.VeeamClient#processHttpResponseForVmRestorePoints so that the backup sync does not break whenever a new property that we don't use is added.

[weizhouapache]

SqlInfo might be a new property of vm restore point, introduced in recent veeam releases

It may be good to add a objectMapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false); to ignore these on org.apache.cloudstack.backup.veeam.VeeamClient#processHttpResponseForVmRestorePoints so that the backup sync does not break whenever a new property that we don't use is added.

Makes sense
Maybe can add a static objectMapper which replaces all new objectmapper instance.