Skip to content

Commit 3133f47

Browse files
jase88j-seifert
authored andcommitted
fix(@schematics/angular): prevent adding test dependencies when minimal option is enabled
1 parent 9850ebc commit 3133f47

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

packages/schematics/angular/application/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ function addDependenciesToPackageJson(options: ApplicationOptions): Rule {
187187
);
188188
}
189189

190-
if (!options.skipTests) {
190+
if (!options.skipTests && !options.minimal) {
191191
rules.push(...addTestRunnerDependencies(options.testRunner, !!options.skipInstall));
192192
}
193193

packages/schematics/angular/application/index_spec.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,18 @@ describe('Application Schematic', () => {
167167
);
168168
});
169169

170+
it(`should not add test dependencies with "minimal" enabled`, async () => {
171+
const tree = await schematicRunner.runSchematic(
172+
'application',
173+
{ ...defaultOptions, minimal: true },
174+
workspaceTree,
175+
);
176+
177+
const packageJson = JSON.parse(tree.readContent('package.json'));
178+
expect(packageJson.devDependencies['vitest']).toBeUndefined();
179+
expect(packageJson.devDependencies['jsdom']).toBeUndefined();
180+
});
181+
170182
it('should install npm dependencies when `skipInstall` is false', async () => {
171183
await schematicRunner.runSchematic(
172184
'application',

0 commit comments

Comments
 (0)