From e125d8f8633731e5ce54c9c1c56a851c998db5c0 Mon Sep 17 00:00:00 2001
From: Kenneth Yang <kjy5@uw.edu>
Date: Tue, 23 Dec 2025 14:12:53 -0800
Subject: [PATCH] Fix code quality problems

---
 .idea/copilot.data.migration.ask.xml       | 6 ++++++
 .idea/copilot.data.migration.ask2agent.xml | 6 ++++++
 .idea/ephys-link.iml                       | 2 +-
 .idea/misc.xml                             | 2 +-
 src/ephys_link/front_end/gui.py            | 4 ++--
 src/ephys_link/utils/startup.py            | 6 ++++--
 tests/utils/test_startup.py                | 7 ++++---
 7 files changed, 24 insertions(+), 9 deletions(-)
 create mode 100644 .idea/copilot.data.migration.ask.xml
 create mode 100644 .idea/copilot.data.migration.ask2agent.xml

diff --git a/.idea/copilot.data.migration.ask.xml b/.idea/copilot.data.migration.ask.xml
new file mode 100644
index 0000000..7ef04e2
--- /dev/null
+++ b/.idea/copilot.data.migration.ask.xml
@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project version="4">
+  <component name="AskMigrationStateService">
+    <option name="migrationStatus" value="COMPLETED" />
+  </component>
+</project>
\ No newline at end of file
diff --git a/.idea/copilot.data.migration.ask2agent.xml b/.idea/copilot.data.migration.ask2agent.xml
new file mode 100644
index 0000000..1f2ea11
--- /dev/null
+++ b/.idea/copilot.data.migration.ask2agent.xml
@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project version="4">
+  <component name="Ask2AgentMigrationStateService">
+    <option name="migrationStatus" value="COMPLETED" />
+  </component>
+</project>
\ No newline at end of file
diff --git a/.idea/ephys-link.iml b/.idea/ephys-link.iml
index 52e1e20..0cd5546 100644
--- a/.idea/ephys-link.iml
+++ b/.idea/ephys-link.iml
@@ -8,7 +8,7 @@
       <excludeFolder url="file://$MODULE_DIR$/venv12" />
       <excludeFolder url="file://$MODULE_DIR$/venv/ephys-link" />
     </content>
-    <orderEntry type="jdk" jdkName="Hatch (ephys-link) [Python 3.14.0]" jdkType="Python SDK" />
+    <orderEntry type="jdk" jdkName="Hatch (ephys-link) [3.14]" jdkType="Python SDK" />
     <orderEntry type="sourceFolder" forTests="false" />
   </component>
 </module>
\ No newline at end of file
diff --git a/.idea/misc.xml b/.idea/misc.xml
index 31648a1..e5b9715 100644
--- a/.idea/misc.xml
+++ b/.idea/misc.xml
@@ -3,7 +3,7 @@
   <component name="Black">
     <option name="sdkName" value="Python 3.12 (ephys-link)" />
   </component>
-  <component name="ProjectRootManager" version="2" project-jdk-name="Hatch (ephys-link) [Python 3.14.0]" project-jdk-type="Python SDK" />
+  <component name="ProjectRootManager" version="2" project-jdk-name="Hatch (ephys-link) [3.14]" project-jdk-type="Python SDK" />
   <component name="PythonCompatibilityInspectionAdvertiser">
     <option name="version" value="3" />
   </component>
diff --git a/src/ephys_link/front_end/gui.py b/src/ephys_link/front_end/gui.py
index 06ad4c6..962b2ad 100644
--- a/src/ephys_link/front_end/gui.py
+++ b/src/ephys_link/front_end/gui.py
@@ -12,7 +12,7 @@
 from os import makedirs
 from os.path import exists, join
 from socket import gethostbyname, gethostname
-from sys import exit
+from sys import exit as sys_exit
 from tkinter import CENTER, RIGHT, BooleanVar, E, IntVar, StringVar, Tk, ttk
 from typing import final
 
@@ -73,7 +73,7 @@ def get_options(self) -> EphysLinkOptions:
 
         # Exit if the user did not submit options.
         if not self._submit:
-            exit(1)
+            sys_exit(1)
 
         # Extract options from GUI.
         options = EphysLinkOptions(
diff --git a/src/ephys_link/utils/startup.py b/src/ephys_link/utils/startup.py
index b08aff0..306f5c6 100644
--- a/src/ephys_link/utils/startup.py
+++ b/src/ephys_link/utils/startup.py
@@ -5,7 +5,9 @@
 from pkgutil import iter_modules
 
 from packaging.version import parse
-from requests import ConnectionError, ConnectTimeout, get
+from requests import ConnectionError as RequestsConnectionError
+from requests import ConnectTimeout as RequestsConnectTimeout
+from requests import get
 from vbl_aquarium.models.ephys_link import EphysLinkOptions
 
 from ephys_link.__about__ import __version__
@@ -45,7 +47,7 @@ def check_for_updates(console: Console) -> None:
         if parse(latest_version) > parse(__version__):
             console.critical_print(f"Update available: {latest_version} (current: {__version__})")
             console.critical_print("Download at: https://github.com/VirtualBrainLab/ephys-link/releases/latest")
-    except (ConnectionError, ConnectTimeout):
+    except (RequestsConnectionError, RequestsConnectTimeout):
         console.error_print("UPDATE", UNABLE_TO_CHECK_FOR_UPDATES_ERROR)
 
 
diff --git a/tests/utils/test_startup.py b/tests/utils/test_startup.py
index 495b51c..f68c02a 100644
--- a/tests/utils/test_startup.py
+++ b/tests/utils/test_startup.py
@@ -3,7 +3,8 @@
 
 import pytest
 from pytest_mock import MockerFixture
-from requests import ConnectionError, ConnectTimeout
+from requests import ConnectionError as RequestsConnectionError
+from requests import ConnectTimeout as RequestsConnectTimeout
 from vbl_aquarium.models.ephys_link import EphysLinkOptions
 
 from ephys_link.__about__ import __version__
@@ -76,9 +77,9 @@ def test_check_for_updates_is_older(self, console: Console, mocker: MockerFixtur
         # Assert: critical_print should be called since an update is available.
         spied_critical_print.assert_called()
 
-    @pytest.mark.parametrize("exception", [ConnectionError, ConnectTimeout])
+    @pytest.mark.parametrize("exception", [RequestsConnectionError, RequestsConnectTimeout])
     def test_check_for_updates_connection_errors(
-        self, exception: ConnectionError | ConnectTimeout, console: Console, mocker: MockerFixture
+        self, exception: RequestsConnectionError | RequestsConnectTimeout, console: Console, mocker: MockerFixture
     ) -> None:
         """Test the check_for_updates function with connection-related errors."""
         # Add mocks and spies.