-
Notifications
You must be signed in to change notification settings - Fork 275
Description
Bug Description:
If a data comment is created at an address and a function is created over top of that address then that data comment cannot be edited or deleted using the comment dialog with the ; hotkey in linear view. The comment dialog defaults to function comments at any address that contains a function, and data comments only when there isn't a function at that location.
Steps To Reproduce:
Please provide all steps required to reproduce the behavior:
- Navigate to a function
- Run
bv.set_comment_at(here, "test") - Hit
;to open the comment dialog - Notice that the existing comment doesn't show up
- Enter a new comment
- Notice that now there is a data comment and a function comment at that location
Expected Behavior:
If there is a data comment already at the address, assume that the user wants to edit the existing data comment. If there is a function comment and a data comment at the same address default to opening the data comment, which allows the user to clear it before creating a function comment if they prefer.