From 0c6f6004294202a0d6f8418fe8d9a42f0c4afeb7 Mon Sep 17 00:00:00 2001 From: Tomasz Tylenda Date: Wed, 4 Feb 2026 18:48:58 +0100 Subject: [PATCH] SONARJAVA-6099 Fix FP on S1135 due to off-by-one error --- .../src/main/java/checks/TodoTagPresenceCheckSample.java | 2 ++ .../org/sonar/java/checks/CommentContainsPatternChecker.java | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/java-checks-test-sources/default/src/main/java/checks/TodoTagPresenceCheckSample.java b/java-checks-test-sources/default/src/main/java/checks/TodoTagPresenceCheckSample.java index f4619fa7ba6..de85c21386a 100644 --- a/java-checks-test-sources/default/src/main/java/checks/TodoTagPresenceCheckSample.java +++ b/java-checks-test-sources/default/src/main/java/checks/TodoTagPresenceCheckSample.java @@ -27,6 +27,8 @@ // Noncompliant@+1 //// TODO Explanation +// Spanish todos + // PreTodo // toDomain package checks; diff --git a/java-checks/src/main/java/org/sonar/java/checks/CommentContainsPatternChecker.java b/java-checks/src/main/java/org/sonar/java/checks/CommentContainsPatternChecker.java index 74fe2d81768..c760ed66eed 100644 --- a/java-checks/src/main/java/org/sonar/java/checks/CommentContainsPatternChecker.java +++ b/java-checks/src/main/java/org/sonar/java/checks/CommentContainsPatternChecker.java @@ -38,7 +38,7 @@ private static boolean isLetterAround(String line, String pattern) { int end = start + pattern.length(); boolean pre = start > 0 && Character.isLetter(line.charAt(start - 1)); - boolean post = end < line.length() - 1 && Character.isLetter(line.charAt(end)); + boolean post = end < line.length() && Character.isLetter(line.charAt(end)); return pre || post; }