|
| 1 | +"""Tests for GitLab commit status integration""" |
| 2 | +import os |
| 3 | +import pytest |
| 4 | +from unittest.mock import patch, MagicMock, call |
| 5 | + |
| 6 | +from socketsecurity.core.scm.gitlab import Gitlab, GitlabConfig |
| 7 | + |
| 8 | + |
| 9 | +def _make_gitlab_config(**overrides): |
| 10 | + defaults = dict( |
| 11 | + commit_sha="abc123def456", |
| 12 | + api_url="https://gitlab.example.com/api/v4", |
| 13 | + project_dir="/builds/test", |
| 14 | + mr_source_branch="feature", |
| 15 | + mr_iid="42", |
| 16 | + mr_project_id="99", |
| 17 | + commit_message="test commit", |
| 18 | + default_branch="main", |
| 19 | + project_name="test-project", |
| 20 | + pipeline_source="merge_request_event", |
| 21 | + commit_author="dev@example.com", |
| 22 | + token="glpat-test", |
| 23 | + repository="test-project", |
| 24 | + is_default_branch=False, |
| 25 | + headers={"Authorization": "Bearer glpat-test", "accept": "application/json"}, |
| 26 | + ) |
| 27 | + defaults.update(overrides) |
| 28 | + return GitlabConfig(**defaults) |
| 29 | + |
| 30 | + |
| 31 | +class TestSetCommitStatus: |
| 32 | + """Test Gitlab.set_commit_status()""" |
| 33 | + |
| 34 | + @patch("socketsecurity.core.scm.gitlab.requests.post") |
| 35 | + def test_calls_correct_url_and_json_payload(self, mock_post): |
| 36 | + mock_post.return_value = MagicMock(status_code=200) |
| 37 | + config = _make_gitlab_config() |
| 38 | + gl = Gitlab(client=MagicMock(), config=config) |
| 39 | + |
| 40 | + gl.set_commit_status("success", "No blocking issues", "https://app.socket.dev/report/123") |
| 41 | + |
| 42 | + mock_post.assert_called_once_with( |
| 43 | + "https://gitlab.example.com/api/v4/projects/99/statuses/abc123def456", |
| 44 | + json={ |
| 45 | + "state": "success", |
| 46 | + "context": "socket-security-commit-status", |
| 47 | + "description": "No blocking issues", |
| 48 | + "ref": "feature", |
| 49 | + "target_url": "https://app.socket.dev/report/123", |
| 50 | + }, |
| 51 | + headers=config.headers, |
| 52 | + ) |
| 53 | + |
| 54 | + @patch("socketsecurity.core.scm.gitlab.requests.post") |
| 55 | + def test_failed_state_payload(self, mock_post): |
| 56 | + mock_post.return_value = MagicMock(status_code=200) |
| 57 | + config = _make_gitlab_config() |
| 58 | + gl = Gitlab(client=MagicMock(), config=config) |
| 59 | + |
| 60 | + gl.set_commit_status("failed", "3 blocking alert(s) found") |
| 61 | + |
| 62 | + payload = mock_post.call_args.kwargs["json"] |
| 63 | + assert payload["state"] == "failed" |
| 64 | + assert payload["description"] == "3 blocking alert(s) found" |
| 65 | + assert "target_url" not in payload |
| 66 | + |
| 67 | + @patch("socketsecurity.core.scm.gitlab.requests.post") |
| 68 | + def test_skipped_when_no_mr_project_id(self, mock_post): |
| 69 | + config = _make_gitlab_config(mr_project_id=None) |
| 70 | + gl = Gitlab(client=MagicMock(), config=config) |
| 71 | + |
| 72 | + gl.set_commit_status("success", "No blocking issues") |
| 73 | + |
| 74 | + mock_post.assert_not_called() |
| 75 | + |
| 76 | + @patch("socketsecurity.core.scm.gitlab.requests.post") |
| 77 | + def test_graceful_error_handling(self, mock_post): |
| 78 | + mock_post.side_effect = Exception("connection error") |
| 79 | + config = _make_gitlab_config() |
| 80 | + gl = Gitlab(client=MagicMock(), config=config) |
| 81 | + |
| 82 | + # Should not raise |
| 83 | + gl.set_commit_status("success", "No blocking issues") |
| 84 | + |
| 85 | + @patch("socketsecurity.core.scm.gitlab.requests.post") |
| 86 | + def test_no_target_url_omitted_from_payload(self, mock_post): |
| 87 | + mock_post.return_value = MagicMock(status_code=200) |
| 88 | + config = _make_gitlab_config() |
| 89 | + gl = Gitlab(client=MagicMock(), config=config) |
| 90 | + |
| 91 | + gl.set_commit_status("success", "No blocking issues", target_url="") |
| 92 | + |
| 93 | + payload = mock_post.call_args.kwargs["json"] |
| 94 | + assert "target_url" not in payload |
| 95 | + |
| 96 | + @patch("socketsecurity.core.scm.gitlab.requests.post") |
| 97 | + def test_auth_fallback_on_401(self, mock_post): |
| 98 | + resp_401 = MagicMock(status_code=401) |
| 99 | + resp_401.raise_for_status.side_effect = Exception("401") |
| 100 | + resp_200 = MagicMock(status_code=200) |
| 101 | + mock_post.side_effect = [resp_401, resp_200] |
| 102 | + |
| 103 | + config = _make_gitlab_config() |
| 104 | + gl = Gitlab(client=MagicMock(), config=config) |
| 105 | + |
| 106 | + gl.set_commit_status("success", "No blocking issues") |
| 107 | + |
| 108 | + assert mock_post.call_count == 2 |
| 109 | + # Second call should use fallback headers (PRIVATE-TOKEN) |
| 110 | + fallback_headers = mock_post.call_args_list[1].kwargs["headers"] |
| 111 | + assert "PRIVATE-TOKEN" in fallback_headers |
| 112 | + |
| 113 | + |
| 114 | +class TestEnableMergePipelineCheck: |
| 115 | + """Test Gitlab.enable_merge_pipeline_check()""" |
| 116 | + |
| 117 | + @patch("socketsecurity.core.scm.gitlab.requests.put") |
| 118 | + def test_calls_correct_url_and_payload(self, mock_put): |
| 119 | + mock_put.return_value = MagicMock(status_code=200) |
| 120 | + config = _make_gitlab_config() |
| 121 | + gl = Gitlab(client=MagicMock(), config=config) |
| 122 | + |
| 123 | + gl.enable_merge_pipeline_check() |
| 124 | + |
| 125 | + mock_put.assert_called_once_with( |
| 126 | + "https://gitlab.example.com/api/v4/projects/99", |
| 127 | + json={"only_allow_merge_if_pipeline_succeeds": True}, |
| 128 | + headers=config.headers, |
| 129 | + ) |
| 130 | + |
| 131 | + @patch("socketsecurity.core.scm.gitlab.requests.put") |
| 132 | + def test_skipped_when_no_mr_project_id(self, mock_put): |
| 133 | + config = _make_gitlab_config(mr_project_id=None) |
| 134 | + gl = Gitlab(client=MagicMock(), config=config) |
| 135 | + |
| 136 | + gl.enable_merge_pipeline_check() |
| 137 | + |
| 138 | + mock_put.assert_not_called() |
| 139 | + |
| 140 | + @patch("socketsecurity.core.scm.gitlab.requests.put") |
| 141 | + def test_auth_fallback_on_401(self, mock_put): |
| 142 | + resp_401 = MagicMock(status_code=401) |
| 143 | + resp_200 = MagicMock(status_code=200) |
| 144 | + mock_put.side_effect = [resp_401, resp_200] |
| 145 | + |
| 146 | + config = _make_gitlab_config() |
| 147 | + gl = Gitlab(client=MagicMock(), config=config) |
| 148 | + |
| 149 | + gl.enable_merge_pipeline_check() |
| 150 | + |
| 151 | + assert mock_put.call_count == 2 |
| 152 | + fallback_headers = mock_put.call_args_list[1].kwargs["headers"] |
| 153 | + assert "PRIVATE-TOKEN" in fallback_headers |
| 154 | + |
| 155 | + @patch("socketsecurity.core.scm.gitlab.requests.put") |
| 156 | + def test_graceful_error_handling(self, mock_put): |
| 157 | + mock_put.side_effect = Exception("connection error") |
| 158 | + config = _make_gitlab_config() |
| 159 | + gl = Gitlab(client=MagicMock(), config=config) |
| 160 | + |
| 161 | + # Should not raise |
| 162 | + gl.enable_merge_pipeline_check() |
| 163 | + |
| 164 | + |
| 165 | +class TestEnableCommitStatusCliArg: |
| 166 | + """Test --enable-commit-status CLI argument parsing""" |
| 167 | + |
| 168 | + def test_default_is_false(self): |
| 169 | + from socketsecurity.config import create_argument_parser |
| 170 | + parser = create_argument_parser() |
| 171 | + args = parser.parse_args([]) |
| 172 | + assert args.enable_commit_status is False |
| 173 | + |
| 174 | + def test_flag_sets_true(self): |
| 175 | + from socketsecurity.config import create_argument_parser |
| 176 | + parser = create_argument_parser() |
| 177 | + args = parser.parse_args(["--enable-commit-status"]) |
| 178 | + assert args.enable_commit_status is True |
| 179 | + |
| 180 | + def test_underscore_alias(self): |
| 181 | + from socketsecurity.config import create_argument_parser |
| 182 | + parser = create_argument_parser() |
| 183 | + args = parser.parse_args(["--enable_commit_status"]) |
| 184 | + assert args.enable_commit_status is True |
0 commit comments