From f59c47c01baca80fcd2bca54ed88de486d655082 Mon Sep 17 00:00:00 2001 From: James Kebinger Date: Wed, 15 Oct 2025 13:03:40 -0500 Subject: [PATCH 1/2] Change Micronaut context attribute key to avoid collision with prefab-sdk MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Update the HTTP request attribute name from "prefab-contexts" to "reforge-sdk-contexts" to prevent conflicts when using this SDK concurrently with the previous prefab-sdk. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- .../micronaut/ServerRequestContextStore.java | 8 ++-- .../ServerRequestContextStoreTest.java | 44 +++++++++---------- 2 files changed, 26 insertions(+), 26 deletions(-) diff --git a/micronaut/src/main/java/com/reforge/sdk/extensions/micronaut/ServerRequestContextStore.java b/micronaut/src/main/java/com/reforge/sdk/extensions/micronaut/ServerRequestContextStore.java index c40cea7..2605f64 100644 --- a/micronaut/src/main/java/com/reforge/sdk/extensions/micronaut/ServerRequestContextStore.java +++ b/micronaut/src/main/java/com/reforge/sdk/extensions/micronaut/ServerRequestContextStore.java @@ -15,11 +15,11 @@ */ public class ServerRequestContextStore implements ContextStore { - public static final String ATTRIBUTE_NAME = "prefab-contexts"; + public static final String ATTRIBUTE_NAME = "reforge-sdk-contexts"; @Override public void addContext(Context context) { - getPrefabContextSet() + getReforgeContextSet() .ifPresentOrElse( prefabContextSet -> prefabContextSet.addContext(context), () -> setContext(context) @@ -50,10 +50,10 @@ public Optional clearContext() { @Override public Optional getContext() { - return getPrefabContextSet().map(ContextSetReadable::readOnlyContextSetView); + return getReforgeContextSet().map(ContextSetReadable::readOnlyContextSetView); } - private Optional getPrefabContextSet() { + private Optional getReforgeContextSet() { return ServerRequestContext .currentRequest() .flatMap(objectHttpRequest -> diff --git a/micronaut/src/test/java/com/reforge/sdk/extensions/micronaut/ServerRequestContextStoreTest.java b/micronaut/src/test/java/com/reforge/sdk/extensions/micronaut/ServerRequestContextStoreTest.java index 8e05ae0..4b64b33 100644 --- a/micronaut/src/test/java/com/reforge/sdk/extensions/micronaut/ServerRequestContextStoreTest.java +++ b/micronaut/src/test/java/com/reforge/sdk/extensions/micronaut/ServerRequestContextStoreTest.java @@ -13,7 +13,7 @@ class ServerRequestContextStoreTest { - ServerRequestContextStore prefabStateStore = new ServerRequestContextStore(); + ServerRequestContextStore reforgeSdkContextStore = new ServerRequestContextStore(); Context userContext = Context.newBuilder("user").put("country", "us").build(); Context serverContext = Context.newBuilder("server").put("az", "2").build(); @@ -29,25 +29,25 @@ void beforeEach() { @Test void getContextReturnsEmpty() { - assertThat(prefabStateStore.getContext()).isEmpty(); + assertThat(reforgeSdkContextStore.getContext()).isEmpty(); } @Test void setContextQuietlyDoesNothing() { - assertThat(prefabStateStore.setContext(userAndServerContextSet)).isEmpty(); - assertThat(prefabStateStore.getContext()).isEmpty(); + assertThat(reforgeSdkContextStore.setContext(userAndServerContextSet)).isEmpty(); + assertThat(reforgeSdkContextStore.getContext()).isEmpty(); } @Test void addContextQuietlyDoesNothing() { - prefabStateStore.addContext(userContext); - assertThat(prefabStateStore.getContext()).isEmpty(); + reforgeSdkContextStore.addContext(userContext); + assertThat(reforgeSdkContextStore.getContext()).isEmpty(); } @Test void clearContextQuietlyDoesNothing() { - assertThat(prefabStateStore.clearContext()).isEmpty(); - assertThat(prefabStateStore.getContext()).isEmpty(); + assertThat(reforgeSdkContextStore.clearContext()).isEmpty(); + assertThat(reforgeSdkContextStore.getContext()).isEmpty(); } } @@ -63,18 +63,18 @@ void beforeEach() { @Test void getContextReturnsEmptyWhenNoContextSet() { - assertThat(prefabStateStore.getContext()).isEmpty(); + assertThat(reforgeSdkContextStore.getContext()).isEmpty(); } @Test void setContextReturnsEmptyWhenNoContextSet() { - assertThat(prefabStateStore.setContext(userAndServerContextSet)).isEmpty(); + assertThat(reforgeSdkContextStore.setContext(userAndServerContextSet)).isEmpty(); } @Test void addContextWhenEmptyUpdatesTheContext() { - prefabStateStore.addContext(userContext); - assertThat(prefabStateStore.getContext()) + reforgeSdkContextStore.addContext(userContext); + assertThat(reforgeSdkContextStore.getContext()) .isPresent() .get() .usingRecursiveComparison() @@ -83,8 +83,8 @@ void addContextWhenEmptyUpdatesTheContext() { @Test void clearReturnsEmpty() { - assertThat(prefabStateStore.clearContext()).isEmpty(); - assertThat(prefabStateStore.getContext()).isEmpty(); + assertThat(reforgeSdkContextStore.clearContext()).isEmpty(); + assertThat(reforgeSdkContextStore.getContext()).isEmpty(); } @Nested @@ -98,12 +98,12 @@ class WithPreExistingContext { @BeforeEach void beforeEach() { - prefabStateStore.setContext(userAndServerContextSet); + reforgeSdkContextStore.setContext(userAndServerContextSet); } @Test void getReturnsExpectedSet() { - assertThat(prefabStateStore.getContext()) + assertThat(reforgeSdkContextStore.getContext()) .isPresent() .get() .usingRecursiveComparison() @@ -112,22 +112,22 @@ void getReturnsExpectedSet() { @Test void clearWorksAsExpected() { - assertThat(prefabStateStore.clearContext()) + assertThat(reforgeSdkContextStore.clearContext()) .isPresent() .get() .usingRecursiveComparison() .isEqualTo(userAndServerContextSet); - assertThat(prefabStateStore.getContext()).isEmpty(); + assertThat(reforgeSdkContextStore.getContext()).isEmpty(); } @Test void setWorksAsExpected() { - assertThat(prefabStateStore.setContext(userContext)) + assertThat(reforgeSdkContextStore.setContext(userContext)) .isPresent() .get() .usingRecursiveComparison() .isEqualTo(userAndServerContextSet); - assertThat(prefabStateStore.getContext()) + assertThat(reforgeSdkContextStore.getContext()) .isPresent() .get() .usingRecursiveComparison() @@ -136,8 +136,8 @@ void setWorksAsExpected() { @Test void addWorksAsExpected() { - prefabStateStore.addContext(newUserContext); - assertThat(prefabStateStore.getContext()) + reforgeSdkContextStore.addContext(newUserContext); + assertThat(reforgeSdkContextStore.getContext()) .isPresent() .get() .usingRecursiveComparison() From d024af7c3ea37e614015c7429791cc482d3676d8 Mon Sep 17 00:00:00 2001 From: James Kebinger Date: Wed, 15 Oct 2025 13:04:29 -0500 Subject: [PATCH 2/2] Bumps version to 1.0.2 --- micronaut/pom.xml | 2 +- pom.xml | 2 +- sdk/pom.xml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/micronaut/pom.xml b/micronaut/pom.xml index 4f4ce22..3c41e38 100644 --- a/micronaut/pom.xml +++ b/micronaut/pom.xml @@ -4,7 +4,7 @@ com.reforge sdk-parent - 1.0.1 + 1.0.2 sdk-micronaut-extension diff --git a/pom.xml b/pom.xml index 68a653e..7553b46 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.reforge sdk-parent - 1.0.1 + 1.0.2 pom Reforge SDK Parent POM Parent POM for Reforge SDK modules providing feature flags, configuration management, and A/B testing capabilities diff --git a/sdk/pom.xml b/sdk/pom.xml index 401e642..cb3b7df 100644 --- a/sdk/pom.xml +++ b/sdk/pom.xml @@ -4,7 +4,7 @@ com.reforge sdk-parent - 1.0.1 + 1.0.2 sdk