BridgeJS: Guard FinalizationRegistry deinit callback against Wasm teardown

krodak · krodak · commit e1755dc5bf6a · 2026-02-19T11:27:04.000+01:00
diff --git a/Plugins/BridgeJS/Sources/BridgeJSLink/BridgeJSLink.swift b/Plugins/BridgeJS/Sources/BridgeJSLink/BridgeJSLink.swift
@@ -50,13 +50,19 @@ public struct BridgeJSLink {
         }
         """
 
+    // The FinalizationRegistry callback wraps state.deinit() in try/catch because the
+    // callback can fire during process shutdown after the Wasm instance is already torn down.
+    // Calling into Wasm at that point throws RuntimeError (memory access / table index out
+    // of bounds). There's nothing to do but swallow it - the process is exiting anyway.
     let swiftHeapObjectClassJs = """
         const swiftHeapObjectFinalizationRegistry = (typeof FinalizationRegistry === "undefined") ? { register: () => {}, unregister: () => {} } : new FinalizationRegistry((state) => {
             if (state.hasReleased) {
                 return;
             }
             state.hasReleased = true;
-            state.deinit(state.pointer);
+            try {
+                state.deinit(state.pointer);
+            } catch {}
         });
 
         /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/ArrayTypes.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/ArrayTypes.js
@@ -340,7 +340,9 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {}
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/DefaultParameters.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/DefaultParameters.js
@@ -277,7 +277,9 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {}
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/DictionaryTypes.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/DictionaryTypes.js
@@ -235,7 +235,9 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {}
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/EnumAssociatedValue.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/EnumAssociatedValue.js
@@ -972,7 +972,9 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {}
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/EnumNamespace.Global.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/EnumNamespace.Global.js
@@ -261,7 +261,9 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {}
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/EnumNamespace.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/EnumNamespace.js
@@ -242,7 +242,9 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {}
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/JSValue.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/JSValue.js
@@ -336,7 +336,9 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {}
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/MixedGlobal.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/MixedGlobal.js
@@ -209,7 +209,9 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {}
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/MixedModules.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/MixedModules.js
@@ -217,7 +217,9 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {}
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/MixedPrivate.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/MixedPrivate.js
@@ -209,7 +209,9 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {}
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/Namespaces.Global.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/Namespaces.Global.js
@@ -217,7 +217,9 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {}
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/Namespaces.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/Namespaces.js
@@ -217,7 +217,9 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {}
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/Optionals.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/Optionals.js
@@ -469,7 +469,9 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {}
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/PropertyTypes.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/PropertyTypes.js
@@ -209,7 +209,9 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {}
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/Protocol.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/Protocol.js
@@ -568,7 +568,9 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {}
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/StaticFunctions.Global.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/StaticFunctions.Global.js
@@ -255,7 +255,9 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {}
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/StaticFunctions.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/StaticFunctions.js
@@ -255,7 +255,9 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {}
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/StaticProperties.Global.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/StaticProperties.Global.js
@@ -214,7 +214,9 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {}
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/StaticProperties.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/StaticProperties.js
@@ -214,7 +214,9 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {}
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/SwiftClass.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/SwiftClass.js
@@ -237,7 +237,9 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {}
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/SwiftClosure.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/SwiftClosure.js
@@ -888,7 +888,9 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {}
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/SwiftStruct.js b/Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/SwiftStruct.js
@@ -483,7 +483,9 @@ export async function createInstantiator(options, swift) {
                     return;
                 }
                 state.hasReleased = true;
-                state.deinit(state.pointer);
+                try {
+                    state.deinit(state.pointer);
+                } catch {}
             });
 
             /// Represents a Swift heap object like a class instance or an actor instance.
diff --git a/Tests/BridgeJSRuntimeTests/Generated/BridgeJS.swift b/Tests/BridgeJSRuntimeTests/Generated/BridgeJS.swift
@@ -11252,6 +11252,18 @@ fileprivate func bjs_SwiftClassSupportImports_jsRoundTripOptionalGreeter_static_
     return bjs_SwiftClassSupportImports_jsRoundTripOptionalGreeter_static_extern(greeterIsSome, greeterPointer)
 }
 
+#if arch(wasm32)
+@_extern(wasm, module: "BridgeJSRuntimeTests", name: "bjs_SwiftClassSupportImports_jsSabotageGreeterDeinit_static")
+fileprivate func bjs_SwiftClassSupportImports_jsSabotageGreeterDeinit_static_extern(_ greeter: UnsafeMutableRawPointer) -> Void
+#else
+fileprivate func bjs_SwiftClassSupportImports_jsSabotageGreeterDeinit_static_extern(_ greeter: UnsafeMutableRawPointer) -> Void {
+    fatalError("Only available on WebAssembly")
+}
+#endif
+@inline(never) fileprivate func bjs_SwiftClassSupportImports_jsSabotageGreeterDeinit_static(_ greeter: UnsafeMutableRawPointer) -> Void {
+    return bjs_SwiftClassSupportImports_jsSabotageGreeterDeinit_static_extern(greeter)
+}
+
 func _$SwiftClassSupportImports_jsRoundTripGreeter(_ greeter: Greeter) throws(JSException) -> Greeter {
     let greeterPointer = greeter.bridgeJSLowerParameter()
     let ret = bjs_SwiftClassSupportImports_jsRoundTripGreeter_static(greeterPointer)
@@ -11268,4 +11280,12 @@ func _$SwiftClassSupportImports_jsRoundTripOptionalGreeter(_ greeter: Optional<G
         throw error
     }
     return Optional<Greeter>.bridgeJSLiftReturn(ret)
+}
+
+func _$SwiftClassSupportImports_jsSabotageGreeterDeinit(_ greeter: Greeter) throws(JSException) -> Void {
+    let greeterPointer = greeter.bridgeJSLowerParameter()
+    bjs_SwiftClassSupportImports_jsSabotageGreeterDeinit_static(greeterPointer)
+    if let error = _swift_js_take_exception() {
+        throw error
+    }
 }
diff --git a/Tests/BridgeJSRuntimeTests/Generated/JavaScript/BridgeJS.json b/Tests/BridgeJSRuntimeTests/Generated/JavaScript/BridgeJS.json
@@ -15643,6 +15643,24 @@
                     "_1" : "null"
                   }
                 }
+              },
+              {
+                "name" : "jsSabotageGreeterDeinit",
+                "parameters" : [
+                  {
+                    "name" : "greeter",
+                    "type" : {
+                      "swiftHeapObject" : {
+                        "_0" : "Greeter"
+                      }
+                    }
+                  }
+                ],
+                "returnType" : {
+                  "void" : {
+
+                  }
+                }
               }
             ]
           }
diff --git a/Tests/BridgeJSRuntimeTests/JavaScript/SwiftClassSupportTests.mjs b/Tests/BridgeJSRuntimeTests/JavaScript/SwiftClassSupportTests.mjs
@@ -9,5 +9,10 @@ export function getImports(importsContext) {
         jsRoundTripOptionalGreeter: (greeter) => {
             return greeter;
         },
+        jsSabotageGreeterDeinit: (greeter) => {
+            greeter.__swiftHeapObjectState.deinit = () => {
+                throw new WebAssembly.RuntimeError("simulated Wasm teardown");
+            };
+        },
     };
-}
+}
diff --git a/Tests/BridgeJSRuntimeTests/SwiftClassSupportTests.swift b/Tests/BridgeJSRuntimeTests/SwiftClassSupportTests.swift
@@ -4,6 +4,7 @@ import JavaScriptKit
 @JSClass struct SwiftClassSupportImports {
     @JSFunction static func jsRoundTripGreeter(_ greeter: Greeter) throws(JSException) -> Greeter
     @JSFunction static func jsRoundTripOptionalGreeter(_ greeter: Greeter?) throws(JSException) -> Greeter?
+    @JSFunction static func jsSabotageGreeterDeinit(_ greeter: Greeter) throws(JSException)
 }
 
 @JSFunction(from: .global) func gc() throws(JSException) -> Void
@@ -28,6 +29,20 @@ final class SwiftClassSupportTests: XCTestCase {
         XCTAssertEqual(jsGreeter["name"].string, "BridgeJS")
     }
 
+    func testFinalizationRegistryHandlesThrowingDeinit() async throws {
+        // Simulate the scenario where a FinalizationRegistry callback fires after the
+        // Wasm instance is torn down. We sabotage the JS wrapper's deinit to throw
+        // WebAssembly.RuntimeError (same error as calling into invalid Wasm memory).
+        // Without the try/catch guard, this crashes the process.
+        let greeter = Greeter(name: "Test")
+        try SwiftClassSupportImports.jsSabotageGreeterDeinit(greeter)
+
+        for _ in 0..<100 {
+            try gc()
+            try await Task.sleep(for: .milliseconds(0))
+        }
+    }
+
     func testJSWrapperIsDeallocatedAfterFinalization() async throws {
         weak var weakGreeter: Greeter?
         var wrapperObject: JSObject?
