Skip to content

Inter-module dependencies are not published #34

@LostLuma

Description

@LostLuma

Depending on a single OSL module does not transitively pull in modules it's dependent on, causing the project to fail to compile.

I ran into this depending on only the networking module:

ploceus.dependOslModule("networking", "0.8.0", GameSide.SERVER)

And using the ServerPlayNetworking.send method from the API it exposes.
Trying to compile the mod now fails because OSL's core module is not present:

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':pumpkin:patch:player-list:server:compileJava'.
> Compilation failed; see the compiler output below.
  /home/lilly/projects/pumpkin-patch/pumpkin/patch/player-list/server/src/main/java/net/lostluma/pumpkin_patch/player_list/impl/server/mixin/PlayerManagerMixin.java:40: error: cannot access net.ornithemc.osl.core.api.util.function.IOConsumer
                        ServerPlayNetworking.send(PlayerListPacket.CHANNEL, packet);
                                            ^
    class file for net.ornithemc.osl.core.api.util.function.IOConsumer not found
  1 error

* Try:
> Check your code and dependencies to fix the compilation error(s)
> Run with --scan to get full insights.```

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions