From 80ed2847d19d3592b7e893fd928ed0b32f862128 Mon Sep 17 00:00:00 2001 From: GeraldST Date: Mon, 13 Apr 2015 21:17:59 +0200 Subject: [PATCH 1/6] Fixed msg_sectcat error There is no field "msg_sectcat", not in the table nor in the code. Therefore viewing feed throws error notice: Undefined property: stdClass::$msg_sectcat view.raw.php --- j30/code/site/views/ninjarsssyndicator/view.html.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/j30/code/site/views/ninjarsssyndicator/view.html.php b/j30/code/site/views/ninjarsssyndicator/view.html.php index d7fdbec..9941a8e 100644 --- a/j30/code/site/views/ninjarsssyndicator/view.html.php +++ b/j30/code/site/views/ninjarsssyndicator/view.html.php @@ -48,7 +48,6 @@ function display($tpl = null) $this->sectlist = $feed->msg_sectlist; $this->excatlist = $feed->msg_excatlist; $this->fulltext = $feed->msg_fulltext; - $this->cat = $feed->msg_sectcat; $this->count = $feed->msg_count; $this->orderby = $feed->msg_orderby; $this->cache = $feed->feed_cache; @@ -69,4 +68,4 @@ function display($tpl = null) parent::display($tpl); } } -?> \ No newline at end of file +?> From fd0e213cbe984a3e9a74b29dbec2b179886cbedf Mon Sep 17 00:00:00 2001 From: GeraldST Date: Mon, 13 Apr 2015 21:19:28 +0200 Subject: [PATCH 2/6] Fixed msg_sectcat error There is no field "msg_sectcat", not in the table nor in the code. Therefore viewing feed throws error notice: Undefined property: stdClass::$msg_sectcat view.raw.php --- j30/code/site/views/ninjarsssyndicator/view.raw.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/j30/code/site/views/ninjarsssyndicator/view.raw.php b/j30/code/site/views/ninjarsssyndicator/view.raw.php index 137e798..95779fe 100644 --- a/j30/code/site/views/ninjarsssyndicator/view.raw.php +++ b/j30/code/site/views/ninjarsssyndicator/view.raw.php @@ -48,7 +48,6 @@ function display($tpl = null) $this->sectlist = $feed->msg_sectlist; $this->excatlist = $feed->msg_excatlist; $this->fulltext = $feed->msg_fulltext; - $this->cat = $feed->msg_sectcat; $this->count = $feed->msg_count; $this->orderby = $feed->msg_orderby; $this->cache = $feed->feed_cache; @@ -69,4 +68,4 @@ function display($tpl = null) parent::display($tpl); } } -?> \ No newline at end of file +?> From c766bcbbd6e1e0213422f18796ce7ffd03ffa044 Mon Sep 17 00:00:00 2001 From: GeraldST Date: Mon, 13 Apr 2015 21:28:44 +0200 Subject: [PATCH 3/6] Added additional default fields for new items Creating a new feed in Backend throws four error notices: Undefined property: stdClass::$XXY, variables need to be initialized properly. --- j30/code/admin/views/feed/view.html.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/j30/code/admin/views/feed/view.html.php b/j30/code/admin/views/feed/view.html.php index c453236..d613012 100644 --- a/j30/code/admin/views/feed/view.html.php +++ b/j30/code/admin/views/feed/view.html.php @@ -140,7 +140,10 @@ public function display($tpl = null) $feed->msg_count = $isNew ? $default->count:$feed->msg_count; $feed->feed_cache = $isNew ? $default->cache:$feed->feed_cache; $feed->feed_description = $isNew ? $default->description : $feed->feed_description; - + $feed->feed_imgUrl = $isNew ? $default->imgUrl : $feed->feed_imgUrl; + $feed->feed_name = $isNew ? '' : $feed->feed_name; + $feed->msg_exitems = $isNew ? '' : $feed->msg_exitems; + $feed->msg_includetags = $isNew ? '' : $feed->msg_includetags; // $this->assignRef('id', $feed->id); // $this->assignRef('name', $feed->feed_name); From 4ca2d51607bddc20d8cd825e58d2f181e3f8f4c5 Mon Sep 17 00:00:00 2001 From: GeraldST Date: Mon, 13 Apr 2015 21:33:08 +0200 Subject: [PATCH 4/6] Changed itemdate Currently LastModifiedDate is taken as an item within feed. This causes much problems (as stated from several users) because the date changes with every modification and item again appears on top of feed. Therefore changed to Create Date. --- .../site/views/ninjarsssyndicator/tmpl/feedcreator.class.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/j30/code/site/views/ninjarsssyndicator/tmpl/feedcreator.class.php b/j30/code/site/views/ninjarsssyndicator/tmpl/feedcreator.class.php index a01efa5..686969a 100644 --- a/j30/code/site/views/ninjarsssyndicator/tmpl/feedcreator.class.php +++ b/j30/code/site/views/ninjarsssyndicator/tmpl/feedcreator.class.php @@ -1012,7 +1012,7 @@ function createFeed() { $this->items[$i]->updated = $this->items[$i]->date; $itemDate = new FeedDate($this->items[$i]->date); $itemUpdated = new FeedDate($this->items[$i]->updated); - $feed.= " ".htmlspecialchars($itemUpdated->rfc822())."\n"; + $feed.= " ".htmlspecialchars($itemDate->rfc822())."\n"; } From d1447a0518cde4f02f795a492c000462b663e10b Mon Sep 17 00:00:00 2001 From: GeraldST Date: Tue, 14 Apr 2015 13:58:07 +0200 Subject: [PATCH 5/6] Update view.raw.php Doing some cleanup - since Joomla 2.5 assignRef() is no longer needed. --- .../views/ninjarsssyndicator/view.raw.php | 21 +------------------ 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/j30/code/site/views/ninjarsssyndicator/view.raw.php b/j30/code/site/views/ninjarsssyndicator/view.raw.php index 95779fe..8178deb 100644 --- a/j30/code/site/views/ninjarsssyndicator/view.raw.php +++ b/j30/code/site/views/ninjarsssyndicator/view.raw.php @@ -22,26 +22,7 @@ function display($tpl = null) //$feed = $this->get( 'Items'); $content = $this->get( 'Content'); $menuItemArray = $this->get('MenuItemArray'); - // $this->assignRef('id', $feed->id); - // $this->assignRef('title', $feed->feed_name); - // $this->assignRef('type', $feed->feed_type); - // $this->assignRef('sectlist', $feed->msg_sectlist); - // $this->assignRef('excatlist', $feed->msg_excatlist); - // $this->assignRef('fulltext', $feed->msg_fulltext); - // $this->assignRef('cat', $feed->msg_sectcat); - // $this->assignRef('count', $feed->msg_count); - // $this->assignRef('orderby', $feed->msg_orderby); - // $this->assignRef('cache', $feed->feed_cache); - // $this->assignRef('description', $feed->feed_description); - // $this->assignRef('renderAuthorFormat', $feed->feed_renderAuthorFormat); - // $this->assignRef('renderHTML', $feed->feed_renderHTML); - // $this->assignRef('renderImages', $feed->feed_renderImages); - // $this->assignRef('FPItemsOnly', $feed->msg_FPItemsOnly); - // $this->assignRef('numWords', $feed->msg_numWords); - // $this->assignRef('imgUrl', $feed->feed_imgUrl); - // $this->assignRef('contentPlugins', $feed->msg_contentPlugins); - // $this->assignRef('content', $content); - // $this->assignRef('menuitemarray',$menuItemArray ); + $this->id = $feed->id; $this->title = $feed->feed_name; $this->type = $feed->feed_type; From 12c11d57e4e51ab9b0fe6d3a141d6c4bfbab720c Mon Sep 17 00:00:00 2001 From: GeraldST Date: Tue, 14 Apr 2015 13:58:48 +0200 Subject: [PATCH 6/6] Update view.html.php Doing some cleanup - since Joomla 2.5 assignRef() is no longer needed. --- .../views/ninjarsssyndicator/view.html.php | 21 +------------------ 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/j30/code/site/views/ninjarsssyndicator/view.html.php b/j30/code/site/views/ninjarsssyndicator/view.html.php index 9941a8e..d4326eb 100644 --- a/j30/code/site/views/ninjarsssyndicator/view.html.php +++ b/j30/code/site/views/ninjarsssyndicator/view.html.php @@ -22,26 +22,7 @@ function display($tpl = null) //$feed = $this->get( 'Items'); $content = $this->get( 'Content'); $menuItemArray = $this->get('MenuItemArray'); - // $this->assignRef('id', $feed->id); - // $this->assignRef('title', $feed->feed_name); - // $this->assignRef('type', $feed->feed_type); - // $this->assignRef('sectlist', $feed->msg_sectlist); - // $this->assignRef('excatlist', $feed->msg_excatlist); - // $this->assignRef('fulltext', $feed->msg_fulltext); - // $this->assignRef('cat', $feed->msg_sectcat); - // $this->assignRef('count', $feed->msg_count); - // $this->assignRef('orderby', $feed->msg_orderby); - // $this->assignRef('cache', $feed->feed_cache); - // $this->assignRef('description', $feed->feed_description); - // $this->assignRef('renderAuthorFormat', $feed->feed_renderAuthorFormat); - // $this->assignRef('renderHTML', $feed->feed_renderHTML); - // $this->assignRef('renderImages', $feed->feed_renderImages); - // $this->assignRef('FPItemsOnly', $feed->msg_FPItemsOnly); - // $this->assignRef('numWords', $feed->msg_numWords); - // $this->assignRef('imgUrl', $feed->feed_imgUrl); - // $this->assignRef('contentPlugins', $feed->msg_contentPlugins); - // $this->assignRef('content', $content); - // $this->assignRef('menuitemarray',$menuItemArray ); + $this->id = $feed->id; $this->title = $feed->feed_name; $this->type = $feed->feed_type;