CCM-12770: Splunk log sending mandatory

Author: sidnhs

infrastructure/modules/lambda/cloudwatch_log_subscription_filter_firehose.tf

@@ -1,5 +1,4 @@
 resource "aws_cloudwatch_log_subscription_filter" "firehose" {
-  count           = var.send_to_firehose ? 1 : 0 # Keeping this optional for now as don't want to break all lambdas using this, can make this mandatory later
   name            = trim(replace(aws_cloudwatch_log_group.main.name, "/", "-"), "-")
   log_group_name  = aws_cloudwatch_log_group.main.name
   filter_pattern  = var.filter_pattern

infrastructure/modules/lambda/variables.tf

@@ -213,12 +213,6 @@ variable "lambda_at_edge" {
   default     = false
 }
 
-variable "send_to_firehose" {
-  type        = bool
-  description = "Enable sending logs to firehose"
-  default     = false
-}
-
 variable "filter_pattern" {
   type        = string
   description = "Filter pattern to use for the log subscription filter"
@@ -228,13 +222,11 @@ variable "filter_pattern" {
 variable "log_destination_arn" {
   type        = string
   description = "Destination ARN to use for the log subscription filter"
-  default     = ""
 }
 
 variable "log_subscription_role_arn" {
   type        = string
   description = "The ARN of the IAM role to use for the log subscription filter"
-  default     = ""
 }
 
 variable "permission_statements" {