Skip to content

Commit b21792f

Browse files
BrandonChanSkyboxBrandonChanSkybox
committed
Addressing feedback
1 parent f0a3d2d commit b21792f

File tree

5 files changed

+126
-239
lines changed

5 files changed

+126
-239
lines changed

‎tools/api-docs-generator-test-snapshots/test/changelog_diffing/__snapshots__/changelogDiffing.spec.ts.snap‎

Lines changed: 4 additions & 77 deletions
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,7 @@ exports[`Changelog Diffing > Generates correct output for changelog diffs > chan
380380
{
381381
"arguments": [
382382
{
383-
"details": [],
383+
"details": null,
384384
"name": "arg",
385385
"type": {
386386
"$old": {
@@ -477,34 +477,7 @@ exports[`Changelog Diffing > Generates correct output for changelog diffs > chan
477477
"call_privilege": []
478478
},
479479
{
480-
"arguments": [
481-
{
482-
"details": [],
483-
"name": "stringArgument",
484-
"type": {
485-
"is_bind_type": false,
486-
"is_errorable": false,
487-
"name": "string",
488-
"valid_range": null
489-
}
490-
},
491-
{
492-
"details": [],
493-
"name": "stringArgumentOptional",
494-
"type": {
495-
"is_bind_type": false,
496-
"is_errorable": false,
497-
"name": "optional",
498-
"optional_type": {
499-
"is_bind_type": false,
500-
"is_errorable": false,
501-
"name": "string",
502-
"valid_range": null
503-
},
504-
"valid_range": null
505-
}
506-
}
507-
],
480+
"arguments": [],
508481
"is_constructor": false,
509482
"is_static": false,
510483
"name": "testMethod",
@@ -725,47 +698,7 @@ exports[`Changelog Diffing > Generates correct output for changelog diffs > chan
725698
"constants": [],
726699
"functions": [
727700
{
728-
"arguments": [
729-
{
730-
"details": [],
731-
"name": "x",
732-
"type": {
733-
"is_bind_type": false,
734-
"is_errorable": false,
735-
"name": "int32",
736-
"valid_range": {
737-
"max": 2147483647,
738-
"min": -2147483648
739-
}
740-
}
741-
},
742-
{
743-
"details": [],
744-
"name": "y",
745-
"type": {
746-
"is_bind_type": false,
747-
"is_errorable": false,
748-
"name": "int32",
749-
"valid_range": {
750-
"max": 2147483647,
751-
"min": -2147483648
752-
}
753-
}
754-
},
755-
{
756-
"details": [],
757-
"name": "z",
758-
"type": {
759-
"is_bind_type": false,
760-
"is_errorable": false,
761-
"name": "int32",
762-
"valid_range": {
763-
"max": 2147483647,
764-
"min": -2147483648
765-
}
766-
}
767-
}
768-
],
701+
"arguments": [],
769702
"is_constructor": true,
770703
"name": "constructor",
771704
"return_type": {
@@ -1070,7 +1003,7 @@ exports[`Changelog Diffing > Generates correct output for changelog diffs > chan
10701003
{
10711004
"arguments": [
10721005
{
1073-
"details": [],
1006+
"details": null,
10741007
"name": "arg",
10751008
"type": {
10761009
"$old": {
@@ -4337,9 +4270,6 @@ export class ClassWithConstructor {
43374270
* @remarks
43384271
* This function can't be called in restricted-execution mode.
43394272
*
4340-
* @param x
4341-
* @param y
4342-
* @param z
43434273
*/
43444274
constructor(x: number, y: number, z: number);
43454275
}
@@ -4650,9 +4580,6 @@ export class ClassWithConstructor {
46504580
* @remarks
46514581
* This function can't be called in restricted-execution mode.
46524582
*
4653-
* @param x
4654-
* @param y
4655-
* @param z
46564583
*/
46574584
constructor(x: number, y: number, z: number);
46584585
/**

‎tools/api-docs-generator-test-snapshots/test/minecraft_version_shipped_stable/__snapshots__/minecraftVersionShippedStable.spec.ts.snap‎

Lines changed: 4 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -14,17 +14,7 @@ exports[`Minecraft Version Shipped Stable > Generates correct output for module
1414
"objects": [],
1515
"functions": [
1616
{
17-
"arguments": [
18-
{
19-
"details": [],
20-
"name": "arg",
21-
"type": {
22-
"is_bind_type": false,
23-
"is_errorable": false,
24-
"name": "string"
25-
}
26-
}
27-
],
17+
"arguments": [],
2818
"is_constructor": false,
2919
"name": "TestFunction",
3020
"return_type": {
@@ -62,17 +52,7 @@ exports[`Minecraft Version Shipped Stable > Generates correct output for module
6252
"objects": [],
6353
"functions": [
6454
{
65-
"arguments": [
66-
{
67-
"details": [],
68-
"name": "arg",
69-
"type": {
70-
"is_bind_type": false,
71-
"is_errorable": false,
72-
"name": "string"
73-
}
74-
}
75-
],
55+
"arguments": [],
7656
"is_constructor": false,
7757
"name": "TestFunction",
7858
"return_type": {
@@ -871,17 +851,7 @@ exports[`Minecraft Version Shipped Stable > Generates correct output for module
871851
"objects": [],
872852
"functions": [
873853
{
874-
"arguments": [
875-
{
876-
"details": [],
877-
"name": "arg",
878-
"type": {
879-
"is_bind_type": false,
880-
"is_errorable": false,
881-
"name": "string"
882-
}
883-
}
884-
],
854+
"arguments": [],
885855
"is_constructor": false,
886856
"name": "TestFunction",
887857
"return_type": {
@@ -919,17 +889,7 @@ exports[`Minecraft Version Shipped Stable > Generates correct output for module
919889
"objects": [],
920890
"functions": [
921891
{
922-
"arguments": [
923-
{
924-
"details": [],
925-
"name": "arg",
926-
"type": {
927-
"is_bind_type": false,
928-
"is_errorable": false,
929-
"name": "string"
930-
}
931-
}
932-
],
892+
"arguments": [],
933893
"is_constructor": false,
934894
"name": "TestFunction",
935895
"return_type": {

0 commit comments

Comments
 (0)