From 9fa2d26c715e59992353c80535ca24df33c476fc Mon Sep 17 00:00:00 2001 From: KerballOne Date: Sat, 9 Aug 2025 13:45:37 -0600 Subject: [PATCH 1/4] Fix RemoteTech API call for connection to unloaded vessels --- src/kOS/AddOns/RemoteTech/RemoteTechConnectivityManager.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/kOS/AddOns/RemoteTech/RemoteTechConnectivityManager.cs b/src/kOS/AddOns/RemoteTech/RemoteTechConnectivityManager.cs index 842d767b9f..d209dcfc25 100644 --- a/src/kOS/AddOns/RemoteTech/RemoteTechConnectivityManager.cs +++ b/src/kOS/AddOns/RemoteTech/RemoteTechConnectivityManager.cs @@ -42,6 +42,10 @@ public double GetDelay(Vessel vessel1, Vessel vessel2) if (!(RemoteTechHook.IsAvailable())) return -1; // default to no connection if RT itself isn't available. double delay = RemoteTechHook.Instance.GetSignalDelayToSatellite(vessel1.id, vessel2.id); + if (Double.IsPositiveInfinity(delay) || delay < 0) + { + delay = RemoteTechHook.Instance.GetShortestSignalDelay(vessel2.id); + } return Double.IsPositiveInfinity(delay) ? -1 : delay; } From a302dddc112dde97c3129379556abc63af9401a5 Mon Sep 17 00:00:00 2001 From: KerballOne Date: Wed, 27 Aug 2025 16:53:34 -0600 Subject: [PATCH 2/4] Delay GetSignalDelayToSatellite broken, should return higher of GetShortestSignalDelay for each vessel --- src/kOS/AddOns/RemoteTech/RemoteTechConnectivityManager.cs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/kOS/AddOns/RemoteTech/RemoteTechConnectivityManager.cs b/src/kOS/AddOns/RemoteTech/RemoteTechConnectivityManager.cs index d209dcfc25..dc52b19693 100644 --- a/src/kOS/AddOns/RemoteTech/RemoteTechConnectivityManager.cs +++ b/src/kOS/AddOns/RemoteTech/RemoteTechConnectivityManager.cs @@ -1,6 +1,7 @@ -using System; using kOS.Communication; using kOS.Module; +using kOS.Safe.Utilities; +using System; namespace kOS.AddOns.RemoteTech { @@ -44,7 +45,8 @@ public double GetDelay(Vessel vessel1, Vessel vessel2) double delay = RemoteTechHook.Instance.GetSignalDelayToSatellite(vessel1.id, vessel2.id); if (Double.IsPositiveInfinity(delay) || delay < 0) { - delay = RemoteTechHook.Instance.GetShortestSignalDelay(vessel2.id); + delay = Math.Max(RemoteTechHook.Instance.GetShortestSignalDelay(vessel1.id), + RemoteTechHook.Instance.GetShortestSignalDelay(vessel2.id)); } return Double.IsPositiveInfinity(delay) ? -1 : delay; } From f41729ee78be6fdf3d02ded16680c768af3550e0 Mon Sep 17 00:00:00 2001 From: KerballOne Date: Wed, 27 Aug 2025 16:56:30 -0600 Subject: [PATCH 3/4] revert library calls --- src/kOS/AddOns/RemoteTech/RemoteTechConnectivityManager.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/kOS/AddOns/RemoteTech/RemoteTechConnectivityManager.cs b/src/kOS/AddOns/RemoteTech/RemoteTechConnectivityManager.cs index dc52b19693..0035e84ab6 100644 --- a/src/kOS/AddOns/RemoteTech/RemoteTechConnectivityManager.cs +++ b/src/kOS/AddOns/RemoteTech/RemoteTechConnectivityManager.cs @@ -1,7 +1,7 @@ +using System; using kOS.Communication; using kOS.Module; -using kOS.Safe.Utilities; -using System; + namespace kOS.AddOns.RemoteTech { From c2a0707fbd93bee1cf073ffd4046180ac32a6219 Mon Sep 17 00:00:00 2001 From: KerballOne Date: Wed, 27 Aug 2025 16:57:11 -0600 Subject: [PATCH 4/4] . --- src/kOS/AddOns/RemoteTech/RemoteTechConnectivityManager.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/kOS/AddOns/RemoteTech/RemoteTechConnectivityManager.cs b/src/kOS/AddOns/RemoteTech/RemoteTechConnectivityManager.cs index 0035e84ab6..72753bbe55 100644 --- a/src/kOS/AddOns/RemoteTech/RemoteTechConnectivityManager.cs +++ b/src/kOS/AddOns/RemoteTech/RemoteTechConnectivityManager.cs @@ -2,7 +2,6 @@ using kOS.Communication; using kOS.Module; - namespace kOS.AddOns.RemoteTech { ///