De-finalized classes to fix mocking. Widened threshold on synchronization tests

Author: dgant

src/main/java/bwapi/Player.java

@@ -18,7 +18,7 @@
  * @see PlayerType
  * @see Race
  */
-public final class Player implements Comparable<Player> {
+public class Player implements Comparable<Player> {
     private final PlayerData playerData;
     private final Game game;
     private final int id;

src/main/java/bwapi/Unit.java

@@ -39,7 +39,7 @@
  * However for units that were owned by the player, {@link #getPlayer} and {@link #getType} will continue to work for units
  * that have been destroyed.
  */
-public final class Unit implements Comparable<Unit> {
+public class Unit implements Comparable<Unit> {
     private static final Set<Order> gatheringGasOrders = EnumSet.of(
             Harvest1, Harvest2, MoveToGas, WaitForGas, HarvestGas, ReturnGas, ResetCollision);
     private static final Set<Order> gatheringMineralOrders = EnumSet.of(

src/test/java/bwapi/SynchronizationTest.java

@@ -73,12 +73,12 @@ public void sync_IfDelay_ThenNoBuffer() {
     public void async_IfBotDelay_ThenClientBuffers() {
         SynchronizationEnvironment environment = new SynchronizationEnvironment();
         environment.configuration
-                .withAsync(true)
-                .withMaxFrameDurationMs(10)
-                .withAsyncFrameBufferCapacity(4);
+            .withAsync(true)
+            .withMaxFrameDurationMs(100)
+            .withAsyncFrameBufferCapacity(4);
 
         environment.onFrame(1, () -> {
-            sleepUnchecked(50);
+            sleepUnchecked(500);
             assertEquals("Bot should be observing an old frame", 1, environment.bwClient.getGame().getFrameCount());
             assertEquals("Client should be as far ahead as the frame buffer allows", 5, environment.liveGameData().getFrameCount());
             assertEquals("Bot should be behind the live game", 4, environment.bwClient.framesBehind());
@@ -97,20 +97,20 @@ public void async_IfBotDelay_ThenClientBuffers() {
     public void async_IfBotDelay_ThenClientStalls() {
         SynchronizationEnvironment environment = new SynchronizationEnvironment();
         environment.configuration
-                .withAsync(true)
-                .withMaxFrameDurationMs(50)
-                .withAsyncFrameBufferCapacity(5);
+            .withAsync(true)
+            .withMaxFrameDurationMs(200)
+            .withAsyncFrameBufferCapacity(5);
 
         environment.onFrame(1, () -> {
-            sleepUnchecked(125);
+            sleepUnchecked(500);
             assertEquals("3: Bot should be observing an old frame", 1, environment.bwClient.getGame().getFrameCount());
             assertEquals("3: Client should have progressed as slowly as possible", 3, environment.liveGameData().getFrameCount());
             assertEquals("3: Bot should be behind the live game by as little as possible", 2, environment.bwClient.framesBehind());
-            sleepUnchecked(50);
+            sleepUnchecked(200);
             assertEquals("4: Bot should be observing an old frame", 1, environment.bwClient.getGame().getFrameCount());
             assertEquals("4: Client should have progressed as slowly as possible", 4, environment.liveGameData().getFrameCount());
             assertEquals("4: Bot should be behind the live game by as little as possible", 3, environment.bwClient.framesBehind());
-            sleepUnchecked(50);
+            sleepUnchecked(200);
             assertEquals("5: Bot should be observing an old frame", 1, environment.bwClient.getGame().getFrameCount());
             assertEquals("5: Client should have progressed as slowly as possible", 5, environment.liveGameData().getFrameCount());
             assertEquals("5: Bot should be behind the live game by as little as possible", 4, environment.bwClient.framesBehind());
@@ -211,7 +211,7 @@ public void async_MeasurePerformance_FrameBufferSizeAndFramesBehind() {
      * Number of milliseconds of leeway to give in potentially noisy performance metrics.
      * Increase if tests are flaky due to variance in execution speed.
      */
-    private final static long MS_MARGIN = 10;
+    private final static long MS_MARGIN = 20;
 
     @Test
     public void MeasurePerformance_BotResponse() {