add support for java17+

Author: JasperGeurtz

.github/workflows/maven.yml

@@ -13,9 +13,11 @@ jobs:
     strategy:
       matrix:
         java:
-         - '8'
-         - '11'
-         #- '17'
+         # Java LTS versions
+         - '8'  # 2030/12
+         - '11' # 2032/01
+         - '17' # 2029/09
+         - '21' # 2031/09
     name: Java ${{ matrix.Java }} sample
     steps:
       - uses: actions/checkout@v2

pom.xml

@@ -61,8 +61,6 @@
                 <artifactId>maven-surefire-plugin</artifactId>
                 <version>2.22.2</version>
                 <configuration>
-<!--                    <parallel>all</parallel> &lt;!&ndash; Run tests in parallel&ndash;&gt;-->
-<!--                    <useUnlimitedThreads>true</useUnlimitedThreads>-->
                     <rerunFailingTestsCount>10</rerunFailingTestsCount>
                     <argLine>-Xms1g -Xmx1g</argLine>
                 </configuration>
@@ -107,6 +105,43 @@
         </plugins>
     </reporting>
 
+    <profiles>
+        <profile>
+            <id>java-12-plus-reflection</id>
+            <activation>
+                <jdk>[12,)</jdk>
+            </activation>
+            <build>
+                <plugins>
+                    <plugin>
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <artifactId>maven-surefire-plugin</artifactId>
+                        <configuration>
+                            <argLine> --add-opens java.base/java.nio=ALL-UNNAMED </argLine>
+                        </configuration>
+                    </plugin>
+
+                    <plugin>
+                        <groupId>org.codehaus.mojo</groupId>
+                        <artifactId>exec-maven-plugin</artifactId>
+                        <executions>
+                            <execution>
+                                <id>run-benchmarks</id>
+                                <configuration>
+                                    <arguments>
+                                        <argument>--add-opens=java.base/java.nio=ALL-UNNAMED</argument>
+                                        <argument>-classpath</argument>
+                                        <classpath/>
+                                        <argument>org.openjdk.jmh.Main</argument>
+                                    </arguments>
+                                </configuration>
+                            </execution>
+                        </executions>
+                    </plugin>
+                </plugins>
+            </build>
+        </profile>
+    </profiles>
     <dependencies>
         <dependency>
             <groupId>no.fiken.oss.junixsocket</groupId>
@@ -119,45 +154,39 @@
             <version>1.0.2</version>
         </dependency>
 
-        <!-- https://mvnrepository.com/artifact/net.java.dev.jna/jna -->
         <dependency>
             <groupId>net.java.dev.jna</groupId>
             <artifactId>jna</artifactId>
             <version>5.12.1</version>
         </dependency>
 
-        <!-- https://mvnrepository.com/artifact/net.java.dev.jna/jna-platform -->
         <dependency>
             <groupId>net.java.dev.jna</groupId>
             <artifactId>jna-platform</artifactId>
             <version>5.12.1</version>
         </dependency>
 
-        <!-- https://mvnrepository.com/artifact/junit/junit -->
         <dependency>
             <groupId>junit</groupId>
             <artifactId>junit</artifactId>
             <version>4.13.2</version>
             <scope>test</scope>
         </dependency>
 
-        <!-- https://mvnrepository.com/artifact/org.mockito/mockito-core -->
         <dependency>
             <groupId>org.mockito</groupId>
             <artifactId>mockito-core</artifactId>
             <version>3.12.4</version>
             <scope>test</scope>
         </dependency>
 
-        <!-- https://mvnrepository.com/artifact/org.assertj/assertj-core -->
         <dependency>
             <groupId>org.assertj</groupId>
             <artifactId>assertj-core</artifactId>
             <version>3.23.1</version>
             <scope>test</scope>
         </dependency>
 
-        <!-- https://mvnrepository.com/artifact/org.openjdk.jmh -->
         <dependency>
             <groupId>org.openjdk.jmh</groupId>
             <artifactId>jmh-core</artifactId>

src/main/java/bwapi/UnsafeTools.java

@@ -21,9 +21,7 @@ private static Object getOrCrash(final Class<?> className, final Object object,
             return result;
 
         } catch (final Exception e) { // or crash...
-            e.printStackTrace();
-            System.exit(-1);
-            return null;
+            throw new RuntimeException(e);
         }
     }
 

src/test/java/bwapi/ClientDataBenchmark.java

@@ -18,11 +18,12 @@ public static class EmptyState {
 
         @Setup(Level.Invocation)
         public void setup() {
+            WrappedBuffer wrappedBuffer = new WrappedBuffer(ClientData.GameData.SIZE);
             game = new Game();
-            game.botClientData().setBuffer(new WrappedBuffer(ClientData.GameData.SIZE));
+            game.botClientData().setBuffer(wrappedBuffer);
+            client = new Client(wrappedBuffer);
             strings = buildStrings();
         }
-
     }
 
     @State(Scope.Thread)
@@ -33,9 +34,11 @@ public static class FilledWithStrings {
 
         @Setup(Level.Invocation)
         public void setup() {
-            data = client.liveClientData().gameData();
+            WrappedBuffer wrappedBuffer = new WrappedBuffer(ClientData.GameData.SIZE);
             game = new Game();
-            game.botClientData().setBuffer(new WrappedBuffer(ClientData.GameData.SIZE));
+            game.botClientData().setBuffer(wrappedBuffer);
+            client = new Client(wrappedBuffer);
+            data = game.botClientData().gameData();
             String[] strings = buildStrings();
             for (String s : strings) {
                 GameDataUtils.addString(client.liveClientData().gameData(), s);