From 8d3943d9d86de5255428512a7f6c89cc5fc95a15 Mon Sep 17 00:00:00 2001 From: Grimm Date: Tue, 4 Feb 2020 02:52:37 +0400 Subject: [PATCH 1/3] Solution (#2) * updarte nodejs.yml * Update nodejs.yml --- .github/workflows/nodejs.yml | 33 +++++++++++++++++++-------------- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index ed236a473..6524a5c85 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -12,18 +12,23 @@ jobs: node-version: [8.x, 10.x, 12.x] steps: - name: Setup Go for use with actions - uses: actions/setup-go@v1.0.0 - with: - # The Go version to download (if necessary) and use. Example: 1.9.3 - version: # optional, default is 1.10 - uses: actions/checkout@v2 - name: Use Node.js ${{ matrix.node-version }} -uses: actions/setup-node@v1 -with: - node-version: ${{ matrix.node-version }} - run: npm install -run: npm run build --if-present - run: npm test + - name: Setup Go for use with actions + - uses: actions/setup-go@v1.0.0 + with: # The Go version to download (if necessary) and use. Example: 1.9.3 + go-version: '1.9.3' + steps: + - uses: actions/checkout@v2 + - name: Use Node.js ${{ matrix.node-version }} + steps: + uses: actions/setup-node@v1 + with: + node-version: ${{ matrix.node_version }} + + run: | + npm install + npm run build --if-present + npm test + env: - CI: true + + CI: true From c155f2520cf0c5922ed0b356aaac4ae30d31a245 Mon Sep 17 00:00:00 2001 From: Grimm Date: Tue, 4 Feb 2020 03:37:13 +0400 Subject: [PATCH 2/3] Update nodejs.yml (#4) --- .github/workflows/nodejs.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 517708949..ef1895655 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -1,8 +1,6 @@ -name: Node.js CI - -on: [push] - +on: [push, pull_request] jobs: + build: runs-on: ubuntu-latest @@ -27,4 +25,6 @@ jobs: - run: npm build --if-present - run: npm test env: - CI: true \ No newline at end of file + CI: true + + From b45158767be882192691ea356b74d1138fd040ed Mon Sep 17 00:00:00 2001 From: Grimm Date: Tue, 4 Feb 2020 03:41:15 +0400 Subject: [PATCH 3/3] Update nodejs.yml --- .github/workflows/nodejs.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index ef1895655..9333c6594 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -26,5 +26,3 @@ jobs: - run: npm test env: CI: true - -