From 1a9f7db96c4a25bf7607e869f4097b192a7766f0 Mon Sep 17 00:00:00 2001 From: Romain Baville Date: Tue, 25 Nov 2025 14:54:26 +0100 Subject: [PATCH 1/4] Clean output message --- .../processing/generic_processing_tools/AttributeMapping.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/geos-processing/src/geos/processing/generic_processing_tools/AttributeMapping.py b/geos-processing/src/geos/processing/generic_processing_tools/AttributeMapping.py index 9eb7aa6fe..264435f51 100644 --- a/geos-processing/src/geos/processing/generic_processing_tools/AttributeMapping.py +++ b/geos-processing/src/geos/processing/generic_processing_tools/AttributeMapping.py @@ -197,5 +197,5 @@ def applyFilter( self: Self ) -> bool: def _logOutputMessage( self: Self ) -> None: """Create and log result messages of the filter.""" self.logger.info( f"The filter { self.logger.name } succeeded." ) - self.logger.info( f"The { self.piece } attributes { self.attributeNames } have been transferred from the source" - " mesh to the final mesh with the { self.piece } mapping." ) + self.logger.info( + f"The { self.piece } attributes { self.attributeNames } have been transferred from the source mesh to the final mesh with the { self.piece } mapping." ) From 6985d94648fbe5b1f9bfdeccc46f320373f0ddcb Mon Sep 17 00:00:00 2001 From: Romain Baville Date: Tue, 25 Nov 2025 14:54:48 +0100 Subject: [PATCH 2/4] fix the piece attribute --- geos-pv/src/geos/pv/plugins/PVAttributeMapping.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/geos-pv/src/geos/pv/plugins/PVAttributeMapping.py b/geos-pv/src/geos/pv/plugins/PVAttributeMapping.py index a8dfc28c2..53fa1251d 100644 --- a/geos-pv/src/geos/pv/plugins/PVAttributeMapping.py +++ b/geos-pv/src/geos/pv/plugins/PVAttributeMapping.py @@ -97,7 +97,7 @@ def setAttributePiece( self: Self, piece: int ) -> None: Args: piece (int): 0 if on points, 1 if on cells. """ - self.onPoints = bool( piece ) + self.onPoints = not bool( piece ) self.Modified() @smproperty.stringvector( From a8090dac15dc099561a9f26f35ac7a1be7bef295 Mon Sep 17 00:00:00 2001 From: Romain Baville Date: Tue, 25 Nov 2025 15:04:46 +0100 Subject: [PATCH 3/4] fix yapf --- .../processing/generic_processing_tools/AttributeMapping.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/geos-processing/src/geos/processing/generic_processing_tools/AttributeMapping.py b/geos-processing/src/geos/processing/generic_processing_tools/AttributeMapping.py index 264435f51..8afb02ab6 100644 --- a/geos-processing/src/geos/processing/generic_processing_tools/AttributeMapping.py +++ b/geos-processing/src/geos/processing/generic_processing_tools/AttributeMapping.py @@ -198,4 +198,5 @@ def _logOutputMessage( self: Self ) -> None: """Create and log result messages of the filter.""" self.logger.info( f"The filter { self.logger.name } succeeded." ) self.logger.info( - f"The { self.piece } attributes { self.attributeNames } have been transferred from the source mesh to the final mesh with the { self.piece } mapping." ) + f"The { self.piece } attributes { self.attributeNames } have been transferred from the source mesh to the final mesh with the { self.piece } mapping." + ) From dc0a2434254b2364d470bd835b159ca51a2174a4 Mon Sep 17 00:00:00 2001 From: Romain Baville Date: Tue, 25 Nov 2025 16:41:01 +0100 Subject: [PATCH 4/4] try to fix the ci --- geos-pv/src/geos/pv/plugins/PVAttributeMapping.py | 1 + 1 file changed, 1 insertion(+) diff --git a/geos-pv/src/geos/pv/plugins/PVAttributeMapping.py b/geos-pv/src/geos/pv/plugins/PVAttributeMapping.py index 53fa1251d..037ce55ab 100644 --- a/geos-pv/src/geos/pv/plugins/PVAttributeMapping.py +++ b/geos-pv/src/geos/pv/plugins/PVAttributeMapping.py @@ -15,6 +15,7 @@ update_paths() from geos.processing.generic_processing_tools.AttributeMapping import AttributeMapping + from paraview.util.vtkAlgorithm import ( # type: ignore[import-not-found] VTKPythonAlgorithmBase, smdomain, smhint, smproperty, smproxy, )