From 237f48752d6271bf13c76885ef3e95ac5146eb27 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 8 Nov 2025 14:37:03 +0000
Subject: [PATCH] fix: resolve Quote struct type mismatch and update tests

The rustfmt commit exposed an issue where the Quote struct in create-issue
was using String for author_url, but fetch-quote was returning Option<String>.

Changes:
- Updated Quote struct in create-issue to use Option<String> for author_url
- Fixed test template to use camelCase field names (authorUrl, authorDescription)
  instead of snake_case (author_url, author_description) to match serde renames
- Removed outdated assertion checking for subscribe_form which was removed
  from the template in a previous commit

All tests now pass.
---
 functions/create-issue/src/model.rs    |  4 ++--
 functions/create-issue/src/template.rs | 15 +++++++--------
 2 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/functions/create-issue/src/model.rs b/functions/create-issue/src/model.rs
index 2bebae5..0f1615b 100644
--- a/functions/create-issue/src/model.rs
+++ b/functions/create-issue/src/model.rs
@@ -49,8 +49,8 @@ pub struct Quote {
     pub author: String,
     #[serde(rename = "authorDescription")]
     pub author_description: String,
-    #[serde(rename = "authorUrl")]
-    pub author_url: String,
+    #[serde(rename = "authorUrl", skip_serializing_if = "Option::is_none")]
+    pub author_url: Option<String>,
 }
 
 #[derive(Deserialize, Serialize, Debug, Clone)]
diff --git a/functions/create-issue/src/template.rs b/functions/create-issue/src/template.rs
index b78c4ca..a8b1a96 100644
--- a/functions/create-issue/src/template.rs
+++ b/functions/create-issue/src/template.rs
@@ -219,7 +219,7 @@ mod tests {
             text: "Computers are useless. They can only give you answers".to_string(),
             author: "Pablo Picasso".to_string(),
             author_description: "Artist".to_string(),
-            author_url: "https://en.wikipedia.org/wiki/Pablo_Picasso".to_string(),
+            author_url: Some("https://en.wikipedia.org/wiki/Pablo_Picasso".to_string()),
         };
 
         let book = Book {
@@ -519,28 +519,28 @@ Book: {{ book.title }}
         }
 
         // Test both naming conventions to understand which one Tera uses
-        let test_desc_rust = r#"{{ quote.author_description }}"#;
+        let test_desc_rust = r#"{{ quote.authorDescription }}"#;
         let result_desc_rust = Tera::one_off(test_desc_rust, &full_context, false);
         match result_desc_rust {
             Ok(rendered) => println!("Rust field name works: {}", rendered),
             Err(e) => println!("Rust field name failed: {}", e),
         }
 
-        let test_desc_json = r#"{{ quote.author_description }}"#;
+        let test_desc_json = r#"{{ quote.authorDescription }}"#;
         let result_desc = Tera::one_off(test_desc_json, &full_context, false);
         match result_desc {
             Ok(rendered) => println!("Description works: {}", rendered),
             Err(e) => println!("Description failed: {}", e),
         }
 
-        let test2b = r#"{{ quote.author_url }}"#;
+        let test2b = r#"{{ quote.authorUrl }}"#;
         let result2b = Tera::one_off(test2b, &full_context, false);
         match result2b {
             Ok(rendered) => println!("Test 2b works: {}", rendered),
             Err(e) => println!("Test 2b failed: {}", e),
         }
 
-        let test2 = r#"> — [{{ quote.author }}]({{ quote.author_url }})"#;
+        let test2 = r#"> — [{{ quote.author }}]({{ quote.authorUrl }})"#;
         let result2 = Tera::one_off(test2, &full_context, false);
         match result2 {
             Ok(rendered) => println!("Test 2 works:\n{}", rendered),
@@ -549,8 +549,8 @@ Book: {{ book.title }}
 
         // Test just the beginning of our actual template
         let partial_template = r#"Hello World
-> "{{ quote.text }}"  
-> — {{ quote.author }}, {{ quote.author_description }}"#;
+> "{{ quote.text }}"
+> — {{ quote.author }}, {{ quote.authorDescription }}"#;
 
         let partial_result = Tera::one_off(partial_template, &full_context, false);
         match partial_result {
@@ -577,7 +577,6 @@ Book: {{ book.title }}
                 assert!(rendered.contains("Building Microservices"));
                 assert!(rendered.contains("An Interactive Guide to SVG Paths"));
                 assert!(rendered.contains("{{ subscriber.metadata.first_name }}"));
-                assert!(rendered.contains("{{ subscribe_form }}"));
             }
             Err(e) => {
                 println!("Template rendering failed: {}", e);