From 29afef9e50bd6ef5ca4fe637d030b0af68b5860b Mon Sep 17 00:00:00 2001 From: Jamie Sinn Date: Tue, 11 Feb 2025 09:09:38 -0500 Subject: [PATCH 1/2] Expecting seconds to be passed in - API returns millis. --- devcycle_python_sdk/managers/config_manager.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devcycle_python_sdk/managers/config_manager.py b/devcycle_python_sdk/managers/config_manager.py index 124e2c6..17f67dc 100644 --- a/devcycle_python_sdk/managers/config_manager.py +++ b/devcycle_python_sdk/managers/config_manager.py @@ -136,7 +136,7 @@ def sse_message(self, message: ld_eventsource.actions.Event): or dvc_data.get("type") is None ): logger.info("DevCycle: Received refetchConfig message - updating config") - self._get_config(dvc_data["lastModified"]) + self._get_config(dvc_data["lastModified"]/1000) def sse_error(self, error: ld_eventsource.actions.Fault): logger.warning(f"DevCycle: Received SSE error: {error}") From a36a68b4ac1707b16e9e40d1a4c0fe5b23a2499e Mon Sep 17 00:00:00 2001 From: Jamie Sinn Date: Tue, 11 Feb 2025 09:22:15 -0500 Subject: [PATCH 2/2] lint --- devcycle_python_sdk/managers/config_manager.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devcycle_python_sdk/managers/config_manager.py b/devcycle_python_sdk/managers/config_manager.py index 17f67dc..9a56078 100644 --- a/devcycle_python_sdk/managers/config_manager.py +++ b/devcycle_python_sdk/managers/config_manager.py @@ -136,7 +136,7 @@ def sse_message(self, message: ld_eventsource.actions.Event): or dvc_data.get("type") is None ): logger.info("DevCycle: Received refetchConfig message - updating config") - self._get_config(dvc_data["lastModified"]/1000) + self._get_config(dvc_data["lastModified"] / 1000.0) def sse_error(self, error: ld_eventsource.actions.Fault): logger.warning(f"DevCycle: Received SSE error: {error}")