From 4e11c2de721504fb130a2ad99664a4d83b66eafa Mon Sep 17 00:00:00 2001 From: Prince Date: Thu, 29 Jan 2026 12:09:19 +0530 Subject: [PATCH 1/7] Improve date picker flow handling --- .../add_task_dialogue/date_picker_input.dart | 29 +++++++++++++++++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/lib/app/utils/add_task_dialogue/date_picker_input.dart b/lib/app/utils/add_task_dialogue/date_picker_input.dart index fe1d6f13..0a4c2b67 100644 --- a/lib/app/utils/add_task_dialogue/date_picker_input.dart +++ b/lib/app/utils/add_task_dialogue/date_picker_input.dart @@ -106,11 +106,36 @@ class _AddTaskDatePickerInputState extends State { firstDate: DateTime.now(), lastDate: DateTime(2101), ); + + // FIX: Check if date was selected before showing time picker + if (picked == null) { + return; // User canceled date picker, exit early + } + + // Only show time picker if date was selected final TimeOfDay? time = await showTimePicker( context: context, initialTime: TimeOfDay.now(), ); - if (picked == null || time == null) return; + + // If user cancels time picker, still set the date with default time + if (time == null) { + setState(() { + // Set date with end-of-day time (23:59) + _selectedDates[forIndex] = picked.add( + const Duration(hours: 23, minutes: 59), + ); + // Update the controller text + _controllers[forIndex].text = + dateToStringForAddTask(_selectedDates[forIndex]!); + }); + if (widget.onDateChanges != null) { + widget.onDateChanges!(_selectedDates); + } + return; + } + + // Both date and time selected setState(() { _selectedDates[forIndex] = picked.add(Duration(hours: time.hour, minutes: time.minute)); @@ -135,4 +160,4 @@ class _AddTaskDatePickerInputState extends State { } return null; } -} +} \ No newline at end of file From 9f7813b7362579669f0d3dde78bac6bf2c63c255 Mon Sep 17 00:00:00 2001 From: Prince Date: Fri, 30 Jan 2026 15:28:08 +0530 Subject: [PATCH 2/7] Preserve taskd.trust when importing and exporting taskrc --- .../manage_task_server_controller.dart | 32 ++++++++++++------- lib/app/utils/taskserver/taskrc.dart | 6 ++++ 2 files changed, 26 insertions(+), 12 deletions(-) diff --git a/lib/app/modules/manageTaskServer/controllers/manage_task_server_controller.dart b/lib/app/modules/manageTaskServer/controllers/manage_task_server_controller.dart index 2fe75484..02b478c2 100644 --- a/lib/app/modules/manageTaskServer/controllers/manage_task_server_controller.dart +++ b/lib/app/modules/manageTaskServer/controllers/manage_task_server_controller.dart @@ -24,7 +24,9 @@ class ManageTaskServerController extends GetxController { late RxString alias; Server? server; Credentials? credentials; + String? trust; final TextEditingController taskrcContentController = TextEditingController(); + RxBool isTaskDServerActive = true.obs; RxBool hideKey = true.obs; @@ -37,13 +39,12 @@ class ManageTaskServerController extends GetxController { alias = RxString(splashController.profilesMap[profile.value] ?? ''); var contents = rc.Taskrc(storage.home.home).readTaskrc(); if (contents != null) { - server = Taskrc.fromString(contents).server; - credentials = Taskrc.fromString(contents).credentials; - } - if (contents != null) { - server = Taskrc.fromString(contents).server; - credentials = Taskrc.fromString(contents).credentials; + final taskrc = Taskrc.fromString(contents); + server = taskrc.server; + credentials = taskrc.credentials; + trust = taskrc.trust; // ⬅️ ADD THIS } + configureCredentialString(); update(); } @@ -53,8 +54,7 @@ class ManageTaskServerController extends GetxController { var contents = await rootBundle.loadString('assets/.taskrc'); rc.Taskrc(storage.home.home).addTaskrc(contents); var taskrc = Taskrc.fromString(contents); - server = taskrc.server; - credentials = taskrc.credentials; + trust = taskrc.trust; for (var entry in { 'taskd.certificate': '.task/first_last.cert.pem', 'taskd.key': '.task/first_last.key.pem', @@ -96,12 +96,12 @@ class ManageTaskServerController extends GetxController { // Check if the server and credentials are present in the Taskrc object if (taskrc.server != null && taskrc.credentials != null) { - // Update the server and credentials variables - server = taskrc.server; credentials = taskrc.credentials; + trust = taskrc.trust; // ⬅️ ADD THIS update(); + // Handle the case when server or credentials are missing in the Taskrc object Navigator.pop(context); @@ -162,8 +162,16 @@ class ManageTaskServerController extends GetxController { if (credentialsString!.value.isNotEmpty && server.toString().isNotEmpty) { //print(credentialsString.value); - taskrcContentController.text = - "taskd.server=$server\ntaskd.credentials=${credentials!.org}/${credentials!.user}/$key"; + var taskrcContent = + "taskd.server=$server\n" + "taskd.credentials=${credentials!.org}/${credentials!.user}/$key"; + + if (trust?.isNotEmpty == true) { + taskrcContent += "\ntaskd.trust=$trust"; // ⬅️ ADD THIS + } + + taskrcContentController.text = taskrcContent; + isTaskDServerActive.value = false; } diff --git a/lib/app/utils/taskserver/taskrc.dart b/lib/app/utils/taskserver/taskrc.dart index 36348b9a..67dd406b 100644 --- a/lib/app/utils/taskserver/taskrc.dart +++ b/lib/app/utils/taskserver/taskrc.dart @@ -7,6 +7,7 @@ class Taskrc { Taskrc({ this.server, this.credentials, + this.trust, // ignore: always_put_required_named_parameters_first required this.pemFilePaths, }); @@ -20,15 +21,20 @@ class Taskrc { factory Taskrc.fromMap(Map taskrc) { var server = taskrc['taskd.server']; var credentials = taskrc['taskd.credentials']; + var trust = taskrc['taskd.trust']; // ⬅️ ADD THIS LINE + return Taskrc( server: (server == null) ? null : Server.fromString(server), credentials: (credentials == null) ? null : Credentials.fromString(credentials), + trust: trust, // ⬅️ ADD THIS LINE pemFilePaths: PemFilePaths.fromTaskrc(taskrc), ); } + final Server? server; final Credentials? credentials; + final String? trust; final PemFilePaths pemFilePaths; } From eb65d403b0c5cc98db010ab95c502760396d8a01 Mon Sep 17 00:00:00 2001 From: Prince Date: Sat, 31 Jan 2026 16:48:35 +0530 Subject: [PATCH 3/7] Added A status Filter For Deleted Tasks --- lib/app/models/filters.dart | 10 ++- .../home/controllers/home_controller.dart | 52 ++++++++++++++- .../home/views/filter_drawer_home_page.dart | 66 ++++++++++--------- 3 files changed, 92 insertions(+), 36 deletions(-) diff --git a/lib/app/models/filters.dart b/lib/app/models/filters.dart index a2296246..67b3ecae 100644 --- a/lib/app/models/filters.dart +++ b/lib/app/models/filters.dart @@ -1,11 +1,13 @@ -import 'package:taskwarrior/app/services/tag_filter.dart'; - class Filters { const Filters({ required this.pendingFilter, required this.waitingFilter, + required this.completedFilter, // NEW + required this.deletedFilter, // NEW required this.togglePendingFilter, required this.toggleWaitingFilter, + required this.toggleCompletedFilter, // NEW + required this.toggleDeletedFilter, // NEW required this.tagFilters, required this.projects, required this.projectFilter, @@ -14,8 +16,12 @@ class Filters { final bool pendingFilter; final bool waitingFilter; + final bool completedFilter; // NEW + final bool deletedFilter; // NEW final void Function() togglePendingFilter; final void Function() toggleWaitingFilter; + final void Function() toggleCompletedFilter; // NEW + final void Function() toggleDeletedFilter; // NEW final TagFilters tagFilters; final dynamic projects; final String projectFilter; diff --git a/lib/app/modules/home/controllers/home_controller.dart b/lib/app/modules/home/controllers/home_controller.dart index a882111a..e92c7902 100644 --- a/lib/app/modules/home/controllers/home_controller.dart +++ b/lib/app/modules/home/controllers/home_controller.dart @@ -50,6 +50,8 @@ class HomeController extends GetxController { final RxBool pendingFilter = false.obs; final RxBool waitingFilter = false.obs; final RxString projectFilter = ''.obs; + final RxBool completedFilter = false.obs; + final RxBool deletedFilter = false.obs; final RxBool tagUnion = false.obs; final RxString selectedSort = ''.obs; final RxSet selectedTags = {}.obs; @@ -101,6 +103,8 @@ class HomeController extends GetxController { everAll([ pendingFilter, waitingFilter, + completedFilter, + deletedFilter, projectFilter, tagUnion, selectedSort, @@ -237,15 +241,35 @@ class HomeController extends GetxController { } void _refreshTasks() { - if (pendingFilter.value) { + + if (deletedFilter.value) { + // Show ONLY deleted tasks + queriedTasks.value = storage.data + .completedData() + .where((task) => task.status == 'deleted') + .toList(); + } + else if (completedFilter.value) { + // Show completed tasks (EXCLUDE deleted) + queriedTasks.value = storage.data + .completedData() + .where((task) => task.status == 'completed') + .toList(); + } + else if (pendingFilter.value) { + // Show pending tasks (default behaviour) queriedTasks.value = storage.data .pendingData() .where((task) => task.status == 'pending') .toList(); - } else { - queriedTasks.value = storage.data.completedData(); + } + else { + // Fallback: pending tasks + queriedTasks.value = storage.data.pendingData(); } + + // Rest of the method stays the same... if (waitingFilter.value) { var currentTime = DateTime.now(); queriedTasks.value = queriedTasks @@ -347,6 +371,22 @@ class HomeController extends GetxController { _refreshTasks(); } + void toggleCompletedFilter() { + completedFilter.toggle(); + if (completedFilter.value) { + deletedFilter.value = false; + } + _refreshTasks(); + } + + void toggleDeletedFilter() { + deletedFilter.toggle(); + if (deletedFilter.value) { + completedFilter.value = false; + } + _refreshTasks(); + } + void toggleProjectFilter(String project) { Query(storage.tabs.tab()).toggleProjectFilter(project); projectFilter.value = Query(storage.tabs.tab()).projectFilter(); @@ -613,11 +653,17 @@ class HomeController extends GetxController { tags: tags, toggleTagFilter: toggleTagFilter, ); + + // REPLACE this entire Filters() instantiation: var filters = Filters( pendingFilter: pendingFilter.value, waitingFilter: waitingFilter.value, + completedFilter: completedFilter.value, // NEW - Add this line + deletedFilter: deletedFilter.value, // NEW - Add this line togglePendingFilter: togglePendingFilter, toggleWaitingFilter: toggleWaitingFilter, + toggleCompletedFilter: toggleCompletedFilter, // NEW - Add this line + toggleDeletedFilter: toggleDeletedFilter, // NEW - Add this line projects: projects, projectFilter: projectFilter.value, toggleProjectFilter: toggleProjectFilter, diff --git a/lib/app/modules/home/views/filter_drawer_home_page.dart b/lib/app/modules/home/views/filter_drawer_home_page.dart index 085a969d..e4a61518 100644 --- a/lib/app/modules/home/views/filter_drawer_home_page.dart +++ b/lib/app/modules/home/views/filter_drawer_home_page.dart @@ -97,17 +97,20 @@ class FilterDrawer extends StatelessWidget { color: tColors.primaryTextColor, )), TextSpan( - text: filters.pendingFilter - ? SentenceManager( - currentLanguage: homeController - .selectedLanguage.value) - .sentences - .filterDrawerPending - : SentenceManager( - currentLanguage: homeController - .selectedLanguage.value) - .sentences - .filterDrawerCompleted, + text: filters.deletedFilter + ? 'Deleted' + : filters.completedFilter + ? SentenceManager( + currentLanguage: + homeController.selectedLanguage.value) + .sentences + .filterDrawerCompleted + : SentenceManager( + currentLanguage: + homeController.selectedLanguage.value) + .sentences + .filterDrawerPending, + style: TextStyle( fontFamily: FontFamily.poppins, fontSize: TaskWarriorFonts.fontSizeMedium, @@ -116,7 +119,16 @@ class FilterDrawer extends StatelessWidget { ], ), ), - onTap: filters.togglePendingFilter, + onTap: () { + if (filters.deletedFilter) { + filters.toggleDeletedFilter(); + } else if (filters.completedFilter) { + filters.toggleCompletedFilter(); + } else { + filters.togglePendingFilter(); + } + }, + textColor: tColors.primaryTextColor, ), ), @@ -137,31 +149,23 @@ class FilterDrawer extends StatelessWidget { mainAxisAlignment: MainAxisAlignment.spaceBetween, children: [ Text( - !filters.waitingFilter - ? SentenceManager( - currentLanguage: homeController - .selectedLanguage.value) - .sentences - .filterDrawerShowWaiting - : SentenceManager( - currentLanguage: homeController - .selectedLanguage.value) - .sentences - .filterDrawerHideWaiting, - style: TextStyle( - fontFamily: FontFamily.poppins, - fontSize: TaskWarriorFonts.fontSizeMedium, - color: tColors.primaryTextColor, - )), + 'Show Deleted', + style: TextStyle( + fontFamily: FontFamily.poppins, + fontSize: TaskWarriorFonts.fontSizeMedium, + color: tColors.primaryTextColor, + ), + ), Switch( - value: filters.waitingFilter, - onChanged: (_) => filters.toggleWaitingFilter(), - ) + value: filters.deletedFilter, + onChanged: (_) => filters.toggleDeletedFilter(), + ), ], ), ), ), ), + const Divider( color: Color.fromARGB(0, 48, 46, 46), ), From 067d869c428471aa19791c68776c249be6c3b940 Mon Sep 17 00:00:00 2001 From: Prince Date: Tue, 3 Feb 2026 11:34:00 +0530 Subject: [PATCH 4/7] fix: auto-dismiss TaskServer not configured banner --- .../home/controllers/home_controller.dart | 50 ++++++++++++++++++- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/lib/app/modules/home/controllers/home_controller.dart b/lib/app/modules/home/controllers/home_controller.dart index e92c7902..780a055a 100644 --- a/lib/app/modules/home/controllers/home_controller.dart +++ b/lib/app/modules/home/controllers/home_controller.dart @@ -1,5 +1,7 @@ // ignore_for_file: use_build_context_synchronously, unrelated_type_equality_checks +import 'package:taskwarrior/app/utils/language/sentences.dart'; + import 'dart:collection'; import 'dart:io'; @@ -47,6 +49,7 @@ import 'package:tutorial_coach_mark/tutorial_coach_mark.dart'; class HomeController extends GetxController { final SplashController splashController = Get.find(); late Storage storage; + final RxBool taskServerBannerShown = false.obs; final RxBool pendingFilter = false.obs; final RxBool waitingFilter = false.obs; final RxString projectFilter = ''.obs; @@ -572,6 +575,44 @@ class HomeController extends GetxController { _refreshTasks(); } + void showTaskServerNotConfiguredBanner(BuildContext context) { + if (taskServerBannerShown.value) return; + + taskServerBannerShown.value = true; + final messenger = ScaffoldMessenger.of(context); + + messenger.clearMaterialBanners(); + + messenger.showMaterialBanner( + MaterialBanner( + content: Text(sentences.homePageTaskWarriorNotConfigured), + actions: [ + TextButton( + onPressed: () { + messenger.hideCurrentMaterialBanner(); + taskServerBannerShown.value = false; // ✅ RESET flag + Get.toNamed(Routes.TASKSERVER_SETUP); + }, + child: Text(sentences.homePageSetup), + ), + TextButton( + onPressed: () { + messenger.hideCurrentMaterialBanner(); + taskServerBannerShown.value = false; // ✅ RESET flag + }, + child: const Text('Dismiss'), + ), + ], + ), + ); + + Future.delayed(const Duration(seconds: 5), () { + messenger.hideCurrentMaterialBanner(); + taskServerBannerShown.value = false; // ✅ RESET flag + }); + } + + void renameTab({ required String tab, required String name, @@ -600,9 +641,14 @@ class HomeController extends GetxController { clientId = await CredentialsStorage.getClientId(); encryptionSecret = await CredentialsStorage.getEncryptionSecret(); if (value) { + if (clientId == null || encryptionSecret == null) { + showTaskServerNotConfiguredBanner(context); + return; + } + synchronize(context, false); - refreshTasks(clientId!, encryptionSecret!); - } else {} + refreshTasks(clientId, encryptionSecret); + } } RxBool syncOnStart = false.obs; From 8c60251683b5a03f29dfec94281a4a8684f6820e Mon Sep 17 00:00:00 2001 From: Prince Date: Wed, 4 Feb 2026 13:53:53 +0530 Subject: [PATCH 5/7] Solved CI --- lib/app/models/filters.dart | 42 ++++++++++++++++++++++++++++++------- 1 file changed, 34 insertions(+), 8 deletions(-) diff --git a/lib/app/models/filters.dart b/lib/app/models/filters.dart index 67b3ecae..c53732d2 100644 --- a/lib/app/models/filters.dart +++ b/lib/app/models/filters.dart @@ -1,13 +1,39 @@ +// lib/app/models/filters.dart + +class TagFilterMetadata { + final String display; + final bool selected; + + TagFilterMetadata({ + required this.display, + required this.selected, + }); +} + +class TagFilters { + final bool tagUnion; + final void Function() toggleTagUnion; + final Map tags; + final void Function(String) toggleTagFilter; + + TagFilters({ + required this.tagUnion, + required this.toggleTagUnion, + required this.tags, + required this.toggleTagFilter, + }); +} + class Filters { const Filters({ required this.pendingFilter, required this.waitingFilter, - required this.completedFilter, // NEW - required this.deletedFilter, // NEW + required this.completedFilter, + required this.deletedFilter, required this.togglePendingFilter, required this.toggleWaitingFilter, - required this.toggleCompletedFilter, // NEW - required this.toggleDeletedFilter, // NEW + required this.toggleCompletedFilter, + required this.toggleDeletedFilter, required this.tagFilters, required this.projects, required this.projectFilter, @@ -16,12 +42,12 @@ class Filters { final bool pendingFilter; final bool waitingFilter; - final bool completedFilter; // NEW - final bool deletedFilter; // NEW + final bool completedFilter; + final bool deletedFilter; final void Function() togglePendingFilter; final void Function() toggleWaitingFilter; - final void Function() toggleCompletedFilter; // NEW - final void Function() toggleDeletedFilter; // NEW + final void Function() toggleCompletedFilter; + final void Function() toggleDeletedFilter; final TagFilters tagFilters; final dynamic projects; final String projectFilter; From 984cb125102ce21d31419bc65b952157dd3ce5a5 Mon Sep 17 00:00:00 2001 From: Prince Date: Wed, 4 Feb 2026 15:13:48 +0530 Subject: [PATCH 6/7] Fix analyzer errors by separating TagFilters model and updating imports --- lib/app/models/filters.dart | 23 +-------- lib/app/models/tag_filters.dart | 25 ++++++++++ .../home/controllers/home_controller.dart | 11 ++-- lib/app/services/tag_filter.dart | 50 ++----------------- 4 files changed, 36 insertions(+), 73 deletions(-) create mode 100644 lib/app/models/tag_filters.dart diff --git a/lib/app/models/filters.dart b/lib/app/models/filters.dart index c53732d2..d29f7a1d 100644 --- a/lib/app/models/filters.dart +++ b/lib/app/models/filters.dart @@ -1,28 +1,7 @@ // lib/app/models/filters.dart -class TagFilterMetadata { - final String display; - final bool selected; +import 'package:taskwarrior/app/models/tag_filters.dart'; - TagFilterMetadata({ - required this.display, - required this.selected, - }); -} - -class TagFilters { - final bool tagUnion; - final void Function() toggleTagUnion; - final Map tags; - final void Function(String) toggleTagFilter; - - TagFilters({ - required this.tagUnion, - required this.toggleTagUnion, - required this.tags, - required this.toggleTagFilter, - }); -} class Filters { const Filters({ diff --git a/lib/app/models/tag_filters.dart b/lib/app/models/tag_filters.dart new file mode 100644 index 00000000..29fa88cb --- /dev/null +++ b/lib/app/models/tag_filters.dart @@ -0,0 +1,25 @@ +// lib/app/models/tag_filters.dart + +class TagFilterMetadata { + const TagFilterMetadata({ + required this.display, + required this.selected, + }); + + final String display; + final bool selected; +} + +class TagFilters { + const TagFilters({ + required this.tagUnion, + required this.toggleTagUnion, + required this.tags, + required this.toggleTagFilter, + }); + + final bool tagUnion; + final void Function() toggleTagUnion; + final Map tags; + final void Function(String) toggleTagFilter; +} diff --git a/lib/app/modules/home/controllers/home_controller.dart b/lib/app/modules/home/controllers/home_controller.dart index 88ad5c30..05ed23c3 100644 --- a/lib/app/modules/home/controllers/home_controller.dart +++ b/lib/app/modules/home/controllers/home_controller.dart @@ -5,6 +5,8 @@ import 'package:taskwarrior/app/utils/language/sentences.dart'; import 'dart:collection'; import 'dart:io'; +import 'package:taskwarrior/app/routes/app_routes.dart'; + import 'package:connectivity_plus/connectivity_plus.dart'; import 'package:flutter/material.dart'; import 'package:get/get.dart'; @@ -20,7 +22,8 @@ import 'package:taskwarrior/app/models/tag_meta_data.dart'; import 'package:taskwarrior/app/modules/home/controllers/widget.controller.dart'; import 'package:taskwarrior/app/modules/splash/controllers/splash_controller.dart'; import 'package:taskwarrior/app/services/deep_link_service.dart'; -import 'package:taskwarrior/app/services/tag_filter.dart'; +import 'package:taskwarrior/app/models/tag_filters.dart'; + import 'package:taskwarrior/app/tour/filter_drawer_tour.dart'; import 'package:taskwarrior/app/tour/home_page_tour.dart'; import 'package:taskwarrior/app/tour/task_swipe_tour.dart'; @@ -581,15 +584,15 @@ class HomeController extends GetxController { messenger.showMaterialBanner( MaterialBanner( - content: Text(sentences.homePageTaskWarriorNotConfigured), + content: Text(Sentences.homePageTaskWarriorNotConfigured), actions: [ TextButton( onPressed: () { messenger.hideCurrentMaterialBanner(); taskServerBannerShown.value = false; // ✅ RESET flag - Get.toNamed(Routes.TASKSERVER_SETUP); + Get.toNamed(Routes.TASKSERVER_SETUP), }, - child: Text(sentences.homePageSetup), + child: Text(Sentences.homePageSetup), ), TextButton( onPressed: () { diff --git a/lib/app/services/tag_filter.dart b/lib/app/services/tag_filter.dart index 2eaa7a56..81fddff8 100644 --- a/lib/app/services/tag_filter.dart +++ b/lib/app/services/tag_filter.dart @@ -1,29 +1,5 @@ import 'package:flutter/material.dart'; - - -class TagFilterMetadata { - const TagFilterMetadata({ - required this.display, - required this.selected, - }); - - final String display; - final bool selected; -} - -class TagFilters { - const TagFilters({ - required this.tagUnion, - required this.toggleTagUnion, - required this.tags, - required this.toggleTagFilter, - }); - - final bool tagUnion; - final void Function() toggleTagUnion; - final Map tags; - final void Function(String) toggleTagFilter; -} +import 'package:taskwarrior/app/models/tag_filters.dart'; class TagFiltersWrap extends StatelessWidget { const TagFiltersWrap(this.filters, {super.key}); @@ -37,32 +13,12 @@ class TagFiltersWrap extends StatelessWidget { children: [ FilterChip( onSelected: (_) => filters.toggleTagUnion(), - label: Text( - filters.tagUnion ? 'OR' : 'AND', - // style: GoogleFonts.poppins( - // color: AppSettings.isDarkMode - // ? TaskWarriorColors.black - // : TaskWarriorColors.white) - ), - // backgroundColor: AppSettings.isDarkMode - // ? TaskWarriorColors.kLightSecondaryBackgroundColor - // : TaskWarriorColors.ksecondaryBackgroundColor, + label: Text(filters.tagUnion ? 'OR' : 'AND'), ), for (var entry in filters.tags.entries) FilterChip( onSelected: (_) => filters.toggleTagFilter(entry.key), - label: Text( - entry.value.display, - // style: GoogleFonts.poppins( - // fontWeight: - // entry.value.selected ? TaskWarriorFonts.bold : null, - // color: AppSettings.isDarkMode - // ? TaskWarriorColors.black - // : TaskWarriorColors.white), - ), - // backgroundColor: AppSettings.isDarkMode - // ? TaskWarriorColors.kLightSecondaryBackgroundColor - // : TaskWarriorColors.kprimaryBackgroundColor, + label: Text(entry.value.display), ), ], ); From b91ed32a78e4106603af6c28d9895c5cd3e1a8b4 Mon Sep 17 00:00:00 2001 From: Prince Date: Wed, 4 Feb 2026 15:36:20 +0530 Subject: [PATCH 7/7] Fix Flutter analyzer errors and update Filters tests --- .../home/controllers/home_controller.dart | 9 ++++++--- test/models/filters_test.dart | 19 ++++++++++++++++++- 2 files changed, 24 insertions(+), 4 deletions(-) diff --git a/lib/app/modules/home/controllers/home_controller.dart b/lib/app/modules/home/controllers/home_controller.dart index 05ed23c3..7ddcfa6e 100644 --- a/lib/app/modules/home/controllers/home_controller.dart +++ b/lib/app/modules/home/controllers/home_controller.dart @@ -5,7 +5,7 @@ import 'package:taskwarrior/app/utils/language/sentences.dart'; import 'dart:collection'; import 'dart:io'; -import 'package:taskwarrior/app/routes/app_routes.dart'; +import 'package:taskwarrior/app/routes/app_pages.dart'; import 'package:connectivity_plus/connectivity_plus.dart'; import 'package:flutter/material.dart'; @@ -45,10 +45,13 @@ import 'package:textfield_tags/textfield_tags.dart'; import 'package:taskwarrior/app/utils/themes/theme_extension.dart'; import 'package:tutorial_coach_mark/tutorial_coach_mark.dart'; + + class HomeController extends GetxController { final SplashController splashController = Get.find(); late Storage storage; final RxBool taskServerBannerShown = false.obs; + final Sentences sentences = Sentences(); final RxBool pendingFilter = false.obs; final RxBool waitingFilter = false.obs; final RxString projectFilter = ''.obs; @@ -584,7 +587,7 @@ class HomeController extends GetxController { messenger.showMaterialBanner( MaterialBanner( - content: Text(Sentences.homePageTaskWarriorNotConfigured), + content: Text(sentences.homePageTaskWarriorNotConfigured), actions: [ TextButton( onPressed: () { @@ -592,7 +595,7 @@ class HomeController extends GetxController { taskServerBannerShown.value = false; // ✅ RESET flag Get.toNamed(Routes.TASKSERVER_SETUP), }, - child: Text(Sentences.homePageSetup), + child: Text(sentences.homePageSetup), ), TextButton( onPressed: () { diff --git a/test/models/filters_test.dart b/test/models/filters_test.dart index 8d577349..c1ea77fd 100644 --- a/test/models/filters_test.dart +++ b/test/models/filters_test.dart @@ -1,9 +1,14 @@ import 'package:flutter_test/flutter_test.dart'; import 'package:taskwarrior/app/models/filters.dart'; -import 'package:taskwarrior/app/services/tag_filter.dart'; +import 'package:taskwarrior/app/models/tag_filters.dart'; + void main() { group('Filters', () { + + late bool completedFilter; + late bool deletedFilter; + late Filters filters; late bool pendingFilter; late bool waitingFilter; @@ -12,6 +17,9 @@ void main() { late Map tags; setUp(() { + completedFilter = false; + deletedFilter = false; + pendingFilter = false; waitingFilter = false; projectFilter = 'TestProject'; @@ -24,12 +32,20 @@ void main() { filters = Filters( pendingFilter: pendingFilter, waitingFilter: waitingFilter, + completedFilter: completedFilter, + deletedFilter: deletedFilter, togglePendingFilter: () { pendingFilter = !pendingFilter; }, toggleWaitingFilter: () { waitingFilter = !waitingFilter; }, + toggleCompletedFilter: () { + completedFilter = !completedFilter; + }, + toggleDeletedFilter: () { + deletedFilter = !deletedFilter; + }, tagFilters: TagFilters( tagUnion: tagUnion, toggleTagUnion: () { @@ -49,6 +65,7 @@ void main() { projectFilter = project; }, ); + }); test('should correctly initialize with given parameters', () {