do not copy a vector; add const

aalkin · aalkin · commit 8a7db0b190b4 · 2026-01-20T14:06:36.000+01:00
diff --git a/Framework/Core/include/Framework/Expressions.h b/Framework/Core/include/Framework/Expressions.h
@@ -712,7 +712,7 @@ std::shared_ptr<gandiva::Projector> createProjectorHelper(size_t nColumns, expre
                                                           std::shared_ptr<arrow::Schema> schema,
                                                           std::vector<std::shared_ptr<arrow::Field>> const& fields);
 
-std::vector<std::shared_ptr<gandiva::Expression>> materializeProjectors(std::vector<expressions::Projector> const& projectors, std::shared_ptr<arrow::Schema> const& inputSchema, std::vector<std::shared_ptr<arrow::Field>> outputFields);
+std::vector<std::shared_ptr<gandiva::Expression>> materializeProjectors(std::vector<expressions::Projector> const& projectors, std::shared_ptr<arrow::Schema> const& inputSchema, std::vector<std::shared_ptr<arrow::Field>> const& outputFields);
 
 template <typename... C>
 std::shared_ptr<gandiva::Projector> createProjectors(framework::pack<C...>, std::vector<std::shared_ptr<arrow::Field>> const& fields, gandiva::SchemaPtr schema)
diff --git a/Framework/Core/src/Expressions.cxx b/Framework/Core/src/Expressions.cxx
@@ -1348,11 +1348,11 @@ OpNode Parser::opFromToken(std::string const& token)
   return OpNode{static_cast<BasicOp>(std::distance(mapping.begin(), locate))};
 }
 
-std::vector<std::shared_ptr<gandiva::Expression>> materializeProjectors(std::vector<expressions::Projector> const& projectors, std::shared_ptr<arrow::Schema> const& inputSchema, std::vector<std::shared_ptr<arrow::Field>> outputFields)
+std::vector<std::shared_ptr<gandiva::Expression>> materializeProjectors(std::vector<expressions::Projector> const& projectors, std::shared_ptr<arrow::Schema> const& inputSchema, std::vector<std::shared_ptr<arrow::Field>> const& outputFields)
 {
   std::vector<std::shared_ptr<gandiva::Expression>> expressions;
   int i = 0;
-  for (auto& p : projectors) {
+  for (auto const& p : projectors) {
     expressions.push_back(
       expressions::makeExpression(
         expressions::createExpressionTree(

Original file line number	Diff line number	Diff line change
`@@ -1348,11 +1348,11 @@ OpNode Parser::opFromToken(std::string const& token)`
`1348`	`1348`	`return OpNode{static_cast<BasicOp>(std::distance(mapping.begin(), locate))};`
`1349`	`1349`	`}`
`1350`	`1350`
`1351`		`-std::vector<std::shared_ptr<gandiva::Expression>> materializeProjectors(std::vector<expressions::Projector> const& projectors, std::shared_ptr<arrow::Schema> const& inputSchema, std::vector<std::shared_ptr<arrow::Field>> outputFields)`
	`1351`	`+std::vector<std::shared_ptr<gandiva::Expression>> materializeProjectors(std::vector<expressions::Projector> const& projectors, std::shared_ptr<arrow::Schema> const& inputSchema, std::vector<std::shared_ptr<arrow::Field>> const& outputFields)`
`1352`	`1352`	`{`
`1353`	`1353`	`std::vector<std::shared_ptr<gandiva::Expression>> expressions;`
`1354`	`1354`	`int i = 0;`
`1355`		`- for (auto& p : projectors) {`
	`1355`	`+ for (auto const& p : projectors) {`
`1356`	`1356`	`expressions.push_back(`
`1357`	`1357`	`expressions::makeExpression(`
`1358`	`1358`	`expressions::createExpressionTree(`